From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "MichaelTiloDressel@t-online.de" <MichaelTiloDressel@t-online.de>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2] allow '%d' pretty format specifier to show decoration
Date: Wed, 20 Aug 2008 11:32:16 -0700 [thread overview]
Message-ID: <7vwsibr0zz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080820180034.GB32005@sigill.intra.peff.net> (Jeff King's message of "Wed, 20 Aug 2008 14:00:34 -0400")
Jeff King <peff@peff.net> writes:
> Is it too loose? Perhaps the enclosing parentheses should be
> automatic,...
I think so. The default output should primarily be for humans.
> - should this turn on --decorate automatically?
Oh, absolutely. If you plan to have different kind of decorations in the
future, then the logic can be "if there is explicit decoration specified,
don't do anything, but if there isn't any, turn the default one on."
Also, if it doesn't already, "--pretty=[t]format:" should make sure parent
rewriting is enabled when %p and %P is used. I didn't look.
next prev parent reply other threads:[~2008-08-20 18:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 12:25 [BUG?] git log does not decorate when custom format is used MichaelTiloDressel
2008-08-20 17:53 ` Jeff King
2008-08-20 17:55 ` [PATCH 1/2] decorate: allow const objects to be decorated Jeff King
2008-08-20 18:00 ` [PATCH 2/2] allow '%d' pretty format specifier to show decoration Jeff King
2008-08-20 18:32 ` Junio C Hamano [this message]
2008-08-20 18:43 ` Johannes Schindelin
2008-08-20 19:01 ` Junio C Hamano
2008-08-20 19:53 ` Johannes Schindelin
2008-09-03 19:36 ` Jeff King
2008-08-20 19:51 ` Michael Dressel
2008-08-20 20:21 ` Junio C Hamano
2008-08-20 21:05 ` Michael Dressel
2008-08-21 5:02 ` "log --pretty=format:" language Teemu Likonen
2008-08-24 18:30 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwsibr0zz.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=MichaelTiloDressel@t-online.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).