From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Anders Melchiorsen <mail@cup.kalibalik.dk>, git@vger.kernel.org
Subject: Re: [PATCH v3] Advertise the ability to abort a commit
Date: Wed, 30 Jul 2008 22:58:13 -0700 [thread overview]
Message-ID: <7vwsj23896.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080731055024.GA17652@sigill.intra.peff.net> (Jeff King's message of "Thu, 31 Jul 2008 01:50:24 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, Jul 30, 2008 at 07:53:11PM +0200, Anders Melchiorsen wrote:
>
>> An empty commit message is now treated as a normal situation, not an error.
>
> As others have commented, I think the right way to say this is probably
> "it is not reported to the user as an error, but still exits with a
> non-zero exit status".
>
> And I think it looks better.
>
> But:
>
>> "# Please enter the commit message for your changes.\n"
>> + "# To abort the commit, use an empty commit message.\n"
>> "# (Comment lines starting with '#' will ");
>
> I still prefer a shortened version of these three lines, as I mentioned
> earlier.
I tend to agree; please make it so ;-)
next prev parent reply other threads:[~2008-07-31 5:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 19:32 [PATCH] Advertise the ability to abort a commit Anders Melchiorsen
2008-07-29 20:12 ` [PATCH v2] " Anders Melchiorsen
2008-07-29 20:51 ` Junio C Hamano
2008-07-29 21:19 ` Anders Melchiorsen
2008-07-30 5:07 ` Jeff King
2008-07-30 5:11 ` Jeff King
2008-07-30 17:53 ` [PATCH v3] " Anders Melchiorsen
2008-07-30 19:01 ` Brian Gernhardt
2008-07-30 21:09 ` Avery Pennarun
2008-07-30 21:16 ` Brian Gernhardt
2008-07-30 21:53 ` Anders Melchiorsen
2008-07-31 5:50 ` Jeff King
2008-07-31 5:58 ` Junio C Hamano [this message]
2008-07-31 6:36 ` [PATCH] " Jeff King
2008-07-31 7:36 ` [PATCH v3] " Jeff King
2008-07-31 10:55 ` Petr Baudis
2008-07-31 11:09 ` Jeff King
2008-07-31 7:28 ` Anders Melchiorsen
2008-07-31 7:32 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwsj23896.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mail@cup.kalibalik.dk \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).