git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Josef 'Jeff' Sipek" <jeffpc@josefsipek.net>
Cc: "Theodore Ts'o" <tytso@MIT.EDU>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] Make guilt work even after git-sh-setup is moved out of the user's path
Date: Mon, 07 Jul 2008 17:56:54 -0700	[thread overview]
Message-ID: <7vwsjxxkfd.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080708003256.GB1880@josefsipek.net> (Josef Sipek's message of "Mon, 7 Jul 2008 20:32:56 -0400")

"Josef 'Jeff' Sipek" <jeffpc@josefsipek.net> writes:

> On Mon, Jul 07, 2008 at 08:03:12PM -0400, Theodore Ts'o wrote:
>> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
>> ---
>>  guilt |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/guilt b/guilt
>> index cdf4e9b..d30d35a 100755
>> --- a/guilt
>> +++ b/guilt
>> @@ -23,7 +23,7 @@ esac
>>  # we change directories ourselves
>>  SUBDIRECTORY_OK=1
>>  
>> -. git-sh-setup
>> +. $(git --exec-path)/git-sh-setup
>
> This seems wrong.
>
> jeffpc@freyr:~$ git --version
> git version 1.5.6.2.247.g923712
> jeffpc@freyr:~$ git --exec-path
> /home/jeffpc/git-bin/bin

Hmm, it is yours that look wrong.

With 1.6.0 preview (aka 'master'):

$ git --version
git version 1.5.6.2.255.gbed62
$ git --exec-path
/home/junio/git-master/libexec/git-core

With 1.5.6 maintenance track (aka 'maint'):

$ ~/git-maint/bin/git --version
git version 1.5.6.2.15.g39f31
$ ~/git-maint/bin/git --exec-path
/home/junio/git-maint/bin

  reply	other threads:[~2008-07-08  0:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-08  0:03 Two quick patches for guilt v0.30 Theodore Ts'o
2008-07-08  0:03 ` [PATCH 1/2] must_commit_first: Make sure the index is up to date Theodore Ts'o
2008-07-08  0:03   ` [PATCH 2/2] Make guilt work even after git-sh-setup is moved out of the user's path Theodore Ts'o
2008-07-08  0:32     ` Josef 'Jeff' Sipek
2008-07-08  0:56       ` Junio C Hamano [this message]
2008-07-08  1:14         ` Josef 'Jeff' Sipek
2008-07-08  1:17           ` Junio C Hamano
2008-07-08  1:28             ` Josef 'Jeff' Sipek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vwsjxxkfd.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jeffpc@josefsipek.net \
    --cc=tytso@MIT.EDU \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).