git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Shawn Bohrer <shawn.bohrer@gmail.com>,
	git@vger.kernel.org, madcoder@debian.org
Subject: Re: [PATCH 1/2] parse_options: Add flag to prevent errors for further processing
Date: Mon, 23 Jun 2008 13:17:16 -0700	[thread overview]
Message-ID: <7vwskfhpo3.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080623195906.GC29569@sigill.intra.peff.net> (Jeff King's message of "Mon, 23 Jun 2008 15:59:07 -0400")

Jeff King <peff@peff.net> writes:

> Now I'm confused: my understanding is that the diff option parser just
> leaves unrecognized stuff in argv. But isn't that what a
> PARSE_OPTIONS_IGNORE_UNKNOWN flag would do, and isn't that wrong?

I was thinking more about the way how the lower level diff_opt_parse()
works by letting the caller to handle things that it itself does not know
how.

But I say this because I am not interested in "-a -b -c <=> -abc" and
haven't thought about how you would go about parsing something like that
sanely with partial knowledge.

  reply	other threads:[~2008-06-23 20:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18  3:03 [RFC] convert shortlog to use parse_options Shawn Bohrer
2008-06-18  3:03 ` [PATCH 1/2] parse_options: Add flag to prevent errors for further processing Shawn Bohrer
2008-06-18  3:03   ` [PATCH 2/2] git shortlog: Modify to use parse_options Shawn Bohrer
2008-06-18  3:21   ` [PATCH 1/2] parse_options: Add flag to prevent errors for further processing Junio C Hamano
2008-06-18  3:30     ` Jeff King
2008-06-18  3:34       ` Jeff King
2008-06-18  5:13       ` Junio C Hamano
2008-06-18 16:50         ` Johannes Schindelin
2008-06-18 18:52           ` Junio C Hamano
2008-06-19 14:25             ` Shawn Bohrer
2008-06-22 19:07               ` Johannes Schindelin
2008-06-23 19:55                 ` Junio C Hamano
2008-06-23 19:59                   ` Jeff King
2008-06-23 20:17                     ` Junio C Hamano [this message]
2008-06-23 20:24                   ` Johannes Schindelin
2008-06-22 17:07         ` Pierre Habouzit
2008-06-23  1:45           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vwskfhpo3.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=madcoder@debian.org \
    --cc=peff@peff.net \
    --cc=shawn.bohrer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).