Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Remi Vanicat <vanicat@debian.org>, git@vger.kernel.org
Subject: Re: [BUG] git filter-branch failed to suppress a file with an accentuated letter in the filename
Date: Fri, 15 Feb 2008 14:21:07 -0800	[thread overview]
Message-ID: <7vwsp5g8to.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LSU.1.00.0802151811240.30505@racer.site> (Johannes Schindelin's message of "Fri, 15 Feb 2008 18:12:57 +0000 (GMT)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> I have to wonder in what century filter-branch was written ;-)
>> 
>> Shouldn't those two lines be:
>> 
>> 	git diff-index -r --name-only $commit |
>>         git update-index --add --replace --remove --stdin
>> 
>> these days, without any of the cut and cruft?
>
> Maybe even using "-z" in both cases?
>
> Having said that, I do not understand why the old code did not work.  Will 
> have a look later today.

The reason mine does not have to use -z is because both end
knows how to C-quote paths under non-z mode.

Now you mention it, it certainly is a bit puzzling why the old
one did not work.

  reply	other threads:[~2008-02-15 22:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-15 16:56 [BUG] git filter-branch failed to suppress a file with an accentuated letter in the filename Remi Vanicat
2008-02-15 17:50 ` Junio C Hamano
2008-02-15 18:12   ` Johannes Schindelin
2008-02-15 22:21     ` Junio C Hamano [this message]
2008-02-16  3:09       ` Johannes Schindelin
2008-02-16 12:48         ` Johannes Schindelin
2008-02-16  6:34   ` Remi Vanicat
2008-02-16  7:54     ` Junio C Hamano
2008-02-16  8:26       ` Remi Vanicat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vwsp5g8to.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=vanicat@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox