From: Junio C Hamano <gitster@pobox.com>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH-v2 4/4] git-commit: add a prepare-commit-msg hook
Date: Tue, 05 Feb 2008 12:02:20 -0800 [thread overview]
Message-ID: <7vwspj9noz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 47A88032.107@gnu.org
Paolo Bonzini <bonzini@gnu.org> writes:
>> I might be missing something
>
> No, you are not.
>
>> but should this not be solved by having the prepare-commit-msg exit
>> 0? I mean, it is conceivable that such a bad error occurs in the
>> hook that the commit should be stopped then and there.
>
> So you say, don't suppress the hook with --no-verify *and* exit if the
> hook returns 1, even if --no-verify is given. That's fine by me.
Fine by me as well, and I would prefer it that way.
prev parent reply other threads:[~2008-02-05 20:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 10:01 [PATCH-v2 1/4] git-commit: support variable number of hook arguments Paolo Bonzini
2008-02-05 10:01 ` [PATCH-v2 2/4] git-commit: set GIT_EDITOR=: if editor will not be launched Paolo Bonzini
2008-02-05 10:01 ` [PATCH-v2 3/4] git-commit: Refactor creation of log message Paolo Bonzini
2008-02-05 10:01 ` [PATCH-v2 4/4] git-commit: add a prepare-commit-msg hook Paolo Bonzini
2008-02-05 15:01 ` Johannes Schindelin
2008-02-05 15:16 ` Paolo Bonzini
2008-02-05 15:21 ` Johannes Schindelin
2008-02-05 15:26 ` Paolo Bonzini
2008-02-05 20:02 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwspj9noz.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=bonzini@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).