git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Sverre Hvammen Johansen" <hvammen@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH] Fast forward strategies only, common, fork and path
Date: Sun, 03 Feb 2008 23:24:29 -0800	[thread overview]
Message-ID: <7vwsplkwuq.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <402c10cd0802032251y626f373eke66c35b200ccf5b1@mail.gmail.com> (Sverre Hvammen Johansen's message of "Sun, 3 Feb 2008 22:51:30 -0800")

"Sverre Hvammen Johansen" <hvammen@gmail.com> writes:

> I intend to also submit a patch that does fast forward in combination
> with a real merge.

Please make the next round an in-line patch.  Attachments cannot
be commented on, and an RFC patch is all about getting comments,
not about being included.  Whitespace breakages do not matter as
much as the final submissions; readability and commentability
matters more.

Instead of adding many new sub-strategies at once, I think it
would make it easier to review to split the patch into (1) code
movement without adding any functionality changes to make your
further changes easier, if such a change is needed in your work
(I did not really look at the attachment carefully), (2) add
logic to find out the set of independent parents to remove
redundant parents (perhaps using show-branch --independent? I
dunno) and conditionally use it, (3) add infrastructure to allow
adding different --ff=<what-to-do>, and then finally (4) a
separate patch for each of <what-to-do>.

I suspect (2) is controversial if made unconditional.  Some
people do not even like the fast-forward "merges" we have
traditionally done.

  reply	other threads:[~2008-02-04  7:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-04  0:54 [RFC/PATCH] Fast forward strategies only, common, fork and path Sverre Hvammen Johansen
2008-02-04  4:49 ` Stefan (metze) Metzmacher
2008-02-04  6:51 ` Sverre Hvammen Johansen
2008-02-04  7:24   ` Junio C Hamano [this message]
2008-02-04  8:06     ` Sverre Hvammen Johansen
2008-02-04  8:22       ` Junio C Hamano
2008-02-05  7:32         ` Sverre Hvammen Johansen
2008-02-05  9:34           ` Jakub Narebski
2008-02-05  9:40           ` Junio C Hamano
2008-02-06  3:46             ` Sverre Hvammen Johansen
2008-02-04  7:13 ` Sverre Hvammen Johansen
2008-02-04  7:31   ` Junio C Hamano
2008-02-04  7:43     ` Sverre Hvammen Johansen
2008-02-04  7:19 ` Sverre Hvammen Johansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vwsplkwuq.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hvammen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).