git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Lars Hjemli" <hjemli@gmail.com>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] Add platform-independent .git "symlink"
Date: Sun, 03 Feb 2008 16:07:48 -0800	[thread overview]
Message-ID: <7vwsplporv.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <8c5c35580802021047o41a7de9fi84a6b33f0f779e2e@mail.gmail.com> (Lars Hjemli's message of "Sat, 2 Feb 2008 19:47:23 +0100")

"Lars Hjemli" <hjemli@gmail.com> writes:

> Maybe this as a compromise?
>
> 	static char buf[PATH_MAX + 9];  /* "GITDIR: " + "\n"  */
> ...
> 	if (!len || buf[len - 1] != '\n')
> 		return NULL;
> 	buf[len - 1] = '\0';
> 	if (prefixcmp(buf, "GITDIR: "))
> 		return NULL;

Perhaps that is easier to read.

For now I haven't picked up any of the "how about this way"
revisions.

  parent reply	other threads:[~2008-02-04  0:08 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-02 10:36 [PATCH] Add platform-independent .git "symlink" Lars Hjemli
2008-02-02 15:02 ` [PATCH] Add tests for .git file Lars Hjemli
2008-02-02 15:56 ` [PATCH] Add platform-independent .git "symlink" Johannes Schindelin
2008-02-02 17:59   ` Lars Hjemli
2008-02-02 18:09     ` Lars Hjemli
2008-02-02 18:19       ` Johannes Schindelin
2008-02-02 18:34         ` Johannes Schindelin
2008-02-04  1:57           ` Shawn O. Pearce
2008-02-04  3:05             ` Junio C Hamano
2008-02-04 14:34               ` Johannes Schindelin
2008-02-04 21:17           ` Brandon Casey
2008-02-04 21:31             ` Johannes Schindelin
2008-02-04 22:08               ` Brandon Casey
2008-02-04 22:19                 ` Johannes Schindelin
2008-02-04 22:44                   ` Brandon Casey
2008-02-04 22:56                     ` Brandon Casey
2008-02-05  0:51                       ` Johannes Schindelin
2008-02-05  0:49                     ` Johannes Schindelin
2008-02-05  2:42                       ` Brandon Casey
2008-02-05 12:57                         ` Johannes Schindelin
2008-02-02 18:47         ` Lars Hjemli
2008-02-03  1:55           ` Johannes Schindelin
2008-02-04  0:07           ` Junio C Hamano [this message]
2008-02-04  0:24             ` Johannes Schindelin
2008-02-04  1:35               ` Shawn O. Pearce
2008-02-04  1:45                 ` Junio C Hamano
2008-02-04  2:00                   ` Shawn O. Pearce
2008-02-04 11:59               ` Lars Hjemli
2008-02-04 14:36                 ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vwsplporv.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=hjemli@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).