From: Junio C Hamano <gitster@pobox.com>
To: Andreas Ericsson <ae@op5.se>
Cc: Brandon Casey <casey@nrlssc.navy.mil>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] git-filter-branch.sh: don't use --default when calling rev-list
Date: Thu, 31 Jan 2008 01:27:09 -0800 [thread overview]
Message-ID: <7vwspqcple.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <47A19211.5090409@op5.se> (Andreas Ericsson's message of "Thu, 31 Jan 2008 10:17:05 +0100")
Andreas Ericsson <ae@op5.se> writes:
> Well, if there's no filter specified it has nothing to do, so erroring out
> in the no-arguments-at-all case would be sensible.
Actually, not erroring out but just returning doing nothing (if
there truly isn't anything to do -- iow, the filtering operation
turns out to be identity function) would be more sensible.
No filter does not necessarily mean identity, by the way. Think
"grafts" ;-).
next prev parent reply other threads:[~2008-01-31 9:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 19:33 [PATCH] filter-branch: assume HEAD if no revision supplied Brandon Casey
2008-01-30 20:35 ` Johannes Schindelin
2008-01-30 21:03 ` Junio C Hamano
2008-01-30 23:35 ` Brandon Casey
2008-01-31 0:13 ` [PATCH 1/2] filter-branch: only print usage information when no arguments supplied Brandon Casey
2008-01-31 1:34 ` Junio C Hamano
2008-01-31 2:05 ` Brandon Casey
2008-01-31 2:44 ` Junio C Hamano
[not found] ` <1201738186-28132-1-git-send-email-casey@nrlssc.navy.mil>
2008-01-31 0:15 ` [PATCH 2/2] git-filter-branch.sh: don't use --default when calling rev-list Brandon Casey
2008-01-31 0:49 ` Johannes Schindelin
2008-01-31 1:35 ` Brandon Casey
2008-01-31 9:17 ` Andreas Ericsson
2008-01-31 9:27 ` Junio C Hamano [this message]
2008-01-31 11:07 ` Johannes Schindelin
2008-01-31 0:16 ` [PATCH] filter-branch: assume HEAD if no revision supplied Johannes Schindelin
2008-01-31 0:20 ` Brandon Casey
2008-01-31 0:41 ` [PATCH] filter-branch docs: remove brackets so not to imply revision arg is optional Brandon Casey
2008-01-31 1:22 ` Junio C Hamano
2008-01-31 1:53 ` Johannes Schindelin
2008-01-31 16:29 ` Brandon Casey
2008-01-31 21:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwspqcple.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=ae@op5.se \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).