From: Junio C Hamano <gitster@pobox.com>
To: Gerrit Pape <pape@smarden.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-pull: don't complain about branch merge config if only fetching tags
Date: Thu, 27 Dec 2007 02:39:17 -0800 [thread overview]
Message-ID: <7vwsr0ifqi.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071227093016.18337.qmail@e6d9fb481b7087.315fe32.mid.smarden.org> (Gerrit Pape's message of "Thu, 27 Dec 2007 09:30:16 +0000")
Gerrit Pape <pape@smarden.org> writes:
>> I've seen this patch on this list in the past, but isn't "git
>> pull -t" a user-error?
>
> If so, we shouldn't advertise the -t switch in the git-pull(1) manpage.
Perhaps. Patches are welcomed as always.
> As it stands, I'd understand 'git pull -t' as 'fetch _all_ tags and
> branch heads and merge according to the configuration'.
Yeah, but that would mean that the current error message needs
to be kept, as that is the logical conclusion of "merge
according to the configuration". Which is not so nice.
Perhaps using the same logic as your patch to detect the case of
"pull --tags and nothing else" case, and exit with non-zero
saying "you probably meant fetch --tags" would be a sane
compromise? I dunno.
next prev parent reply other threads:[~2007-12-27 10:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 12:44 [PATCH] git-pull: don't complain about branch merge config if only fetching tags Gerrit Pape
2007-12-21 16:35 ` Junio C Hamano
2007-12-27 9:30 ` Gerrit Pape
2007-12-27 10:39 ` Junio C Hamano [this message]
2007-12-27 14:46 ` [PATCH] git-pull: warn if only fetching tags with the -t switch Gerrit Pape
2007-12-28 6:37 ` Junio C Hamano
2007-12-28 7:19 ` Junio C Hamano
2007-12-28 17:32 ` Daniel Barkalow
2007-12-28 21:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwsr0ifqi.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).