* [PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too
@ 2007-11-26 12:42 Denis Cheng
2007-12-01 2:36 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Denis Cheng @ 2007-11-26 12:42 UTC (permalink / raw)
To: git; +Cc: dengxw
---
gitweb/gitweb.perl | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 491a3f4..ff5daa7 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3786,6 +3786,8 @@ sub git_search_grep_body {
"<td class=\"link\">" .
$cgi->a({-href => href(action=>"commit", hash=>$co{'id'})}, "commit") .
" | " .
+ $cgi->a({-href => href(action=>"commitdiff", hash=>$co{'id'})}, "commitdiff") .
+ " | " .
$cgi->a({-href => href(action=>"tree", hash=>$co{'tree'}, hash_base=>$co{'id'})}, "tree");
print "</td>\n" .
"</tr>\n";
--
1.5.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too
2007-11-26 12:42 [PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too Denis Cheng
@ 2007-12-01 2:36 ` Junio C Hamano
2007-12-01 3:04 ` Jakub Narebski
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2007-12-01 2:36 UTC (permalink / raw)
To: Denis Cheng; +Cc: git, dengxw, jnareb, pasky
I'll queue this to my tree but will drop if I hear objections from
gitweb people CC'ed over the weekend.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too
2007-12-01 2:36 ` Junio C Hamano
@ 2007-12-01 3:04 ` Jakub Narebski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Narebski @ 2007-12-01 3:04 UTC (permalink / raw)
To: git
Junio C Hamano wrote:
> I'll queue this to my tree but will drop if I hear objections from
> gitweb people CC'ed over the weekend.
This just ads link to 'search' view to 'commitdiff'; looks very nice.
Acked-by: Jakub Narebski <jnareb@gmail.com>
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-12-01 3:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-26 12:42 [PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too Denis Cheng
2007-12-01 2:36 ` Junio C Hamano
2007-12-01 3:04 ` Jakub Narebski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).