Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: CJ van den Berg <cj@vdbonline.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-submodule: Fix a typo
Date: Wed, 04 Jul 2007 09:59:35 -0700	[thread overview]
Message-ID: <7vwsxggl54.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070704162214.GA28542@prefect.vdbonline.net> (CJ van den Berg's message of "Wed, 4 Jul 2007 18:22:14 +0200")

CJ van den Berg <cj@vdbonline.com> writes:

> This typo breaks the output of git submodule status.
>
> ---
>  git-submodule.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 0ba0161..277fadc 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -234,7 +234,7 @@ modules_list()
>  			continue;
>  		fi
>  		revname=$(unset GIT_DIR && cd "$path" && git describe --tags $sha1)
> -		set_name_rev "$path" $"sha1"
> +		set_name_rev "$path" "$sha1"
>  		if git diff-files --quiet -- "$path"
>  		then
>  			say " $sha1 $path$revname"

Thanks.  There is another, probably from a cut-n-paste.

      reply	other threads:[~2007-07-04 16:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-04 16:22 [PATCH] git-submodule: Fix a typo CJ van den Berg
2007-07-04 16:59 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vwsxggl54.fsf@assigned-by-dhcp.cox.net \
    --to=gitster@pobox.com \
    --cc=cj@vdbonline.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox