From: Junio C Hamano <junkio@cox.net>
To: "Alex Riesen" <raa.lkml@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] read-tree -m -u: avoid getting confused by intermediate symlinks.
Date: Fri, 11 May 2007 10:10:53 -0700 [thread overview]
Message-ID: <7vwszfb80y.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 81b0412b0705110708y7e3a9024p9e117e2da84ae916@mail.gmail.com
"Alex Riesen" <raa.lkml@gmail.com> writes:
> On 5/11/07, Junio C Hamano <junkio@cox.net> wrote:
>> @@ -268,6 +268,8 @@ static void unlink_entry(char *name)
>> {
>> char *cp, *prev;
>>
>> + if (has_symlink_leading_path(name))
>> + return;
>
> This can slow down the unlink case quiet considerably.
> Maybe the symlink paths can be cached?
Yes it can, and probably doable.
This is called once per each path that disappears from the
result, relative to the current tree. The number of calls to
this function is potentially quite large.
next prev parent reply other threads:[~2007-05-11 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 7:13 [PATCH] read-tree -m -u: avoid getting confused by intermediate symlinks Junio C Hamano
2007-05-11 14:08 ` Alex Riesen
2007-05-11 17:10 ` Junio C Hamano [this message]
2007-05-11 20:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwszfb80y.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).