From: Junio C Hamano <junkio@cox.net>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix memory leak in "connect.c".
Date: Wed, 06 Sep 2006 21:09:58 -0700 [thread overview]
Message-ID: <7vwt8g48rt.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060907055952.dafffe2b.chriscool@tuxfamily.org> (Christian Couder's message of "Thu, 7 Sep 2006 05:59:52 +0200")
Christian Couder <chriscool@tuxfamily.org> writes:
> sq_quote allocates some memory that should be freed.
That's technically correct, but the code you are touching is
immediately before exec() or die() so I chose to be sloppy and
short ;-).
With sq_quote_buf() (which was introduced with 77d604 Oct 10
2005), you should be able to directly write into the command[]
buffer, I think. The code you touched predates that function
(b10d0e July 8 2005).
next prev parent reply other threads:[~2006-09-07 4:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-07 3:59 [PATCH] Fix memory leak in "connect.c" Christian Couder
2006-09-07 4:09 ` Junio C Hamano [this message]
2006-09-11 4:43 ` [PATCH 0/2] Command preparation cleanup in "connect.c" (was: [PATCH] Fix memory leak in "connect.c".) Christian Couder
2006-09-11 4:59 ` [PATCH 1/2] Move add_to_string to "quote.c" and make it extern Christian Couder
2006-09-11 5:04 ` [PATCH 2/2] Fix a memory leak in "connect.c" and die if command too long Christian Couder
2006-09-11 6:03 ` [PATCH 0/2] Command preparation cleanup in "connect.c" Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwt8g48rt.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).