From: Junio C Hamano <junkio@cox.net>
To: Brian Gernhardt <benji@silverinsanity.com>
Cc: git@vger.kernel.org, Shawn Pearce <spearce@spearce.org>
Subject: Re: [PATCH] Include local config before platform tweaks
Date: Wed, 06 Sep 2006 00:18:32 -0700 [thread overview]
Message-ID: <7vwt8h8nuf.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060906033151.GB30540@spearce.org> (Shawn Pearce's message of "Tue, 5 Sep 2006 23:31:51 -0400")
Shawn Pearce <spearce@spearce.org> writes:
> Junio C Hamano <junkio@cox.net> wrote:
>> Brian Gernhardt <benji@silverinsanity.com> writes:
>>
>> > Having config.mak included after the platform tweaks ignores NO_FINK
>> > or NO_DARWIN_PORTS in that file. Simply including the config earlier
>> > fixes that.
>>
>> I vaguely recall that this was brought up before, and the
>> conclusion was that the include location is correct but the way
>> darwin bits were done was wrong. I do not recall the details
>> but does anybody on the list know?
>
> I think we just need to move the NO_FINK stuff below the include;
> like this:
Thanks Shawn. Brian does Shawn's patch work for you?
next prev parent reply other threads:[~2006-09-06 7:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-05 22:00 [PATCH] Include local config before platform tweaks Brian Gernhardt
2006-09-05 22:13 ` Junio C Hamano
2006-09-06 3:31 ` Shawn Pearce
2006-09-06 7:18 ` Junio C Hamano [this message]
2006-09-06 19:13 ` Brian Gernhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwt8h8nuf.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=benji@silverinsanity.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).