git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Luben Tuikov <ltuikov@yahoo.com>
Cc: git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH 4/4] gitweb: No periods for error messages
Date: Sat, 05 Aug 2006 00:03:17 -0700	[thread overview]
Message-ID: <7vwt9nekay.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060805010307.17651.qmail@web31807.mail.mud.yahoo.com> (Luben Tuikov's message of "Fri, 4 Aug 2006 18:03:07 -0700 (PDT)")

Luben Tuikov <ltuikov@yahoo.com> writes:

> --- Junio C Hamano <junkio@cox.net> wrote:
>
>> I tend to prefer ending each sentence with a full stop.
>
> I've never seen this in, among other things,
>   - kernel messages
>   - errno messages
>   - web server messages
>   - RFC text describing error messages, (web services),
>   - etc.

Comparing

	git grep \( -e die --or -e die \) --and -e '\."' -- '*.c'

and

	git grep \( -e die --or -e die \) --and --not -e '\."' -- '*.c'

tells me that we omit periods, mostly.

> I was going for was consistency.  I'd say apply Jacob's [6/5].

Well, [6/5] is on top of [1/5] which had the problem of
parroting unsanitized user input, so I'd rather use a clean
patch that does only this error message cleanups.

      reply	other threads:[~2006-08-05  7:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-04 22:16 [PATCH 4/4] gitweb: No periods for error messages Luben Tuikov
2006-08-05  0:20 ` Junio C Hamano
2006-08-05  1:03   ` Luben Tuikov
2006-08-05  7:03     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vwt9nekay.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=ltuikov@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).