git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ondřej Bílka" <neleai@seznam.cz>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Fix generic typos in comments
Date: Sun, 21 Jul 2013 15:29:19 -0700	[thread overview]
Message-ID: <7vy58zr1hc.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130720190707.GA30044@domone> ("Ondřej Bílka"'s message of "Sat, 20 Jul 2013 21:07:07 +0200")

Ondřej Bílka <neleai@seznam.cz> writes:

> Hi, I wrote a tool that effectively fixes typos in comments and only in
> comments.
> It can be downloaded here:
>
> https://github.com/neleai/stylepp
>
> For typos you need identify them, write replacement dictionary and run
> STYLEPP/script/stylepp_skeleton stylepp_fix_comment
>
> Here generic dictionary is used that was taken from wikipedia.
> https://github.com/neleai/stylepp/blob/master/maintained/dictionary_wiki

Thanks, but sorry we cannot use this patch as-is (even if it were
signed-off and came with a proper log message).

The patch touches phrases somebody may find questionable at many
different levels.

 - "lowercase ok" and "fall thru" are quite acceptable colloquial
   forms; if the person who DID the real work chose to write these
   in such a way, I do not see a reason for us to update it to a
   different preference.

 - There are outright typoes that noboddy would disagree with,
   e.g. s/sinse/since/.

      parent reply	other threads:[~2013-07-21 22:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-20 19:07 [PATCH 1/2] Fix generic typos in comments Ondřej Bílka
2013-07-20 19:13 ` [PATCH 2/2] Fix " Ondřej Bílka
2013-07-20 19:39   ` brian m. carlson
2013-07-20 20:56     ` American or British English? Ondřej Bílka
2013-07-20 19:51   ` [PATCH 2/2] Fix typos in comments Ramkumar Ramachandra
2013-07-20 20:30     ` Ondřej Bílka
2013-07-21 22:32   ` Junio C Hamano
2013-07-21 22:29 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vy58zr1hc.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=neleai@seznam.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).