From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@inf.ethz.ch>
Cc: "Torsten Bögershausen" <tboegi@web.de>, git@vger.kernel.org
Subject: Re: [PATCH] t0000: do not use export X=Y
Date: Mon, 08 Jul 2013 08:20:55 -0700 [thread overview]
Message-ID: <7vy59h13jc.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <8761wli0fe.fsf@linux-k42r.v.cablecom.net> (Thomas Rast's message of "Mon, 8 Jul 2013 16:36:05 +0200")
Thomas Rast <trast@inf.ethz.ch> writes:
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> The shell syntax "export X=Y A=B" is not understood by all shells.
>>
>> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
>> ---
>> t/t0000-basic.sh | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
>> index 5c32288..10be52b 100755
>> --- a/t/t0000-basic.sh
>> +++ b/t/t0000-basic.sh
>> @@ -53,7 +53,8 @@ run_sub_test_lib_test () {
>> # Pretend we're a test harness. This prevents
>> # test-lib from writing the counts to a file that will
>> # later be summarized, showing spurious "failed" tests
>> - export HARNESS_ACTIVE=t &&
>> + HARNESS_ACTIVE=t &&
>> + export HARNESS_ACTIVE &&
>> cd "$name" &&
>> cat >"$name.sh" <<-EOF &&
>> #!$SHELL_PATH
>
> Ack. Sorry for breaking this -- I suppose test-lint would have caught
> me out?
Or I should have. Thanks for catching.
prev parent reply other threads:[~2013-07-08 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 9:21 [PATCH] t0000: do not use export X=Y Torsten Bögershausen
2013-07-08 14:36 ` Thomas Rast
2013-07-08 15:20 ` [PATCH 1/2] t9902: fix 'test A == B' to use = operator Thomas Rast
2013-07-08 15:20 ` [PATCH 2/2] test-lint: detect 'export FOO=bar' Thomas Rast
2013-07-08 19:31 ` Torsten Bögershausen
2013-07-09 9:28 ` Thomas Rast
2013-07-09 9:53 ` Torsten Bögershausen
2013-07-08 17:20 ` [PATCH 1/2] t9902: fix 'test A == B' to use = operator Junio C Hamano
2013-07-09 9:27 ` Thomas Rast
2013-07-08 15:20 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy59h13jc.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).