* [PATCH] t/Makefile: don't define TEST_RESULTS_DIRECTORY recursively
@ 2013-05-06 12:35 John Keeping
2013-05-06 15:20 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: John Keeping @ 2013-05-06 12:35 UTC (permalink / raw)
To: git
Cc: Johannes Schindelin, Thomas Rast, Jeff King, Junio C Hamano,
John Keeping
Commit 54bb901 (t/Makefile: fix result handling with
TEST_OUTPUT_DIRECTORY - 2013-04-26) incorrectly defined
TEST_RESULTS_DIRECTORY relative to itself, when it should be relative to
TEST_OUTPUT_DIRECTORY. Fix this.
Signed-off-by: John Keeping <john@keeping.me.uk>
---
t/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/Makefile b/t/Makefile
index 11de5da..ebb7371 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -16,7 +16,7 @@ DEFAULT_TEST_TARGET ?= test
TEST_LINT ?= test-lint-duplicates test-lint-executable
ifdef TEST_OUTPUT_DIRECTORY
-TEST_RESULTS_DIRECTORY = $(TEST_RESULTS_DIRECTORY)/test-results
+TEST_RESULTS_DIRECTORY = $(TEST_OUTPUT_DIRECTORY)/test-results
else
TEST_RESULTS_DIRECTORY = test-results
endif
--
1.8.3.rc0.149.g98a72f2.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] t/Makefile: don't define TEST_RESULTS_DIRECTORY recursively
2013-05-06 12:35 [PATCH] t/Makefile: don't define TEST_RESULTS_DIRECTORY recursively John Keeping
@ 2013-05-06 15:20 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2013-05-06 15:20 UTC (permalink / raw)
To: John Keeping; +Cc: git, Johannes Schindelin, Thomas Rast, Jeff King
John Keeping <john@keeping.me.uk> writes:
> Commit 54bb901 (t/Makefile: fix result handling with
> TEST_OUTPUT_DIRECTORY - 2013-04-26) incorrectly defined
> TEST_RESULTS_DIRECTORY relative to itself, when it should be relative to
> TEST_OUTPUT_DIRECTORY. Fix this.
>
> Signed-off-by: John Keeping <john@keeping.me.uk>
> ---
> t/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, I missed this one.
> diff --git a/t/Makefile b/t/Makefile
> index 11de5da..ebb7371 100644
> --- a/t/Makefile
> +++ b/t/Makefile
> @@ -16,7 +16,7 @@ DEFAULT_TEST_TARGET ?= test
> TEST_LINT ?= test-lint-duplicates test-lint-executable
>
> ifdef TEST_OUTPUT_DIRECTORY
> -TEST_RESULTS_DIRECTORY = $(TEST_RESULTS_DIRECTORY)/test-results
> +TEST_RESULTS_DIRECTORY = $(TEST_OUTPUT_DIRECTORY)/test-results
> else
> TEST_RESULTS_DIRECTORY = test-results
> endif
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-06 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 12:35 [PATCH] t/Makefile: don't define TEST_RESULTS_DIRECTORY recursively John Keeping
2013-05-06 15:20 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).