From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
christophe@kn.gl, git@vger.kernel.org
Subject: Re: [PATCH] test-bzr: portable shell and utf-8 strings for Mac OS
Date: Fri, 12 Apr 2013 15:40:19 -0700 [thread overview]
Message-ID: <7vy5cnbcfg.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAMP44s1UqCNKHFMcN0pJo_tJ1UeHDET7vxFJhqj8X=YibgDt0Q@mail.gmail.com> (Felipe Contreras's message of "Fri, 12 Apr 2013 16:27:32 -0500")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> On Fri, Apr 12, 2013 at 4:18 PM, Torsten Bögershausen <tboegi@web.de> wrote:
>> Make the shell script more portable:
>> - Split export X=Y into 2 lines
>> - Use printf instead of echo -e
>>
>> Use UTF-8 code points which are not decomposed by the filesystem:
>> Code points like "á" will be decomposed by Mac OS X.
>> bzr is unable to find the file "á" on disk.
>> Use code points from unicode which can not be decomposed.
>> In other words, the precompsed form use the same bytes as decomposed.
>
> Looks good to me.
Thanks, both. Applied.
prev parent reply other threads:[~2013-04-12 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 21:18 [PATCH] test-bzr: portable shell and utf-8 strings for Mac OS Torsten Bögershausen
2013-04-12 21:27 ` Felipe Contreras
2013-04-12 22:40 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy5cnbcfg.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=christophe@kn.gl \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).