From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: David Michael <fedora.dm0@gmail.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h
Date: Fri, 14 Dec 2012 15:17:00 -0800 [thread overview]
Message-ID: <7vy5h0usur.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <50CB8C80.6040802@kdbg.org> (Johannes Sixt's message of "Fri, 14 Dec 2012 21:30:56 +0100")
Johannes Sixt <j6t@kdbg.org> writes:
> Am 14.12.2012 20:57, schrieb David Michael:
>> This platform previously included strings.h automatically. However, the
>> build system now requires an explicit option to do so.
>>
>> Signed-off-by: David Michael <fedora.dm0@gmail.com>
>> ---
>> Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Makefile b/Makefile
>> index fb78f7f..e84b0cb 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
>> # Added manually, see above.
>> NEEDS_SSL_WITH_CURL = YesPlease
>> HAVE_LIBCHARSET_H = YesPlease
>> + HAVE_STRINGS_H = YesPlease
>> NEEDS_LIBICONV = YesPlease
>> NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
>> NO_SYS_SELECT_H = UnfortunatelyYes
>
> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this
> should be squashed into the previous patch, shouldn't it?
Correct; otherwise 3/4 would break build on that platform.
next prev parent reply other threads:[~2012-12-14 23:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 19:57 [PATCH 4/4] Declare that HP NonStop systems require strings.h David Michael
2012-12-14 20:30 ` Johannes Sixt
2012-12-14 22:45 ` Joachim Schmitz
2012-12-14 23:17 ` Junio C Hamano [this message]
[not found] <00c601cdda4c$eb6be9a0$c243bce0$@schmitz-digital.de>
2012-12-14 23:16 ` Johannes Sixt
2012-12-15 8:25 ` Joachim Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy5h0usur.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=fedora.dm0@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).