From: Junio C Hamano <gitster@pobox.com>
To: Thomas Ackermann <th.acker66@arcor.de>
Cc: git@vger.kernel.org, philipoakley@iee.org, peff@peff.net,
git@drmicha.warpmail.net
Subject: Re: Aw: Re: Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files
Date: Thu, 18 Oct 2012 13:40:29 -0700 [thread overview]
Message-ID: <7vy5j3ldj6.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <634888125.421937.1350580792693.JavaMail.ngmail@webmail11.arcor-online.net> (Thomas Ackermann's message of "Thu, 18 Oct 2012 19:19:52 +0200 (CEST)")
Thomas Ackermann <th.acker66@arcor.de> writes:
> Yes; in e2399e9 the following hunks where left out from the patch to update-hook-example.txt:
>
> @@ -111,12 +114,12 @@ then
>
> info "Found matching head pattern: '$head_pattern'"
> for user_pattern in $user_patterns; do
> - info "Checking user: '$username' against pattern: '$user_pattern'"
> - matchlen=$(expr "$username" : "$user_pattern")
> - if test "$matchlen" = "${#username}"
> - then
> - grant "Allowing user: '$username' with pattern: '$user_pattern'"
> - fi
> + info "Checking user: '$username' against pattern: '$user_pattern'"
> + matchlen=$(expr "$username" : "$user_pattern")
> + if test "$matchlen" = "${#username}"
> + then
> + grant "Allowing user: '$username' with pattern: '$user_pattern'"
> + fi
> done
> deny "The user is not in the access list for this branch"
> done
> @@ -149,13 +152,13 @@ then
>
> info "Found matching head pattern: '$head_pattern'"
> for group_pattern in $group_patterns; do
> - for groupname in $groups; do
> - info "Checking group: '$groupname' against pattern: '$group_pattern'"
> - matchlen=$(expr "$groupname" : "$group_pattern")
> - if test "$matchlen" = "${#groupname}"
> - then
> - grant "Allowing group: '$groupname' with pattern: '$group_pattern'"
> - fi
> + for groupname in $groups; do
> + info "Checking group: '$groupname' against pattern: '$group_pattern'"
> + matchlen=$(expr "$groupname" : "$group_pattern")
> + if test "$matchlen" = "${#groupname}"
> + then
> + grant "Allowing group: '$groupname' with pattern: '$group_pattern'"
> + fi
> done
> done
> deny "None of the user's groups are in the access list for this branch"
Yuck. That is because I almost always apply patches with whitespace
breakage fix. The above two hunks, if taken as patches to shell
script, does nothing but adding whitespace breakages, turning tab
indent into expanded runs of spaces, and that was why the tool
dropped them.
Resurrected; will queue the result later.
Thanks.
prev parent reply other threads:[~2012-10-18 20:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 17:19 Aw: Re: Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files Thomas Ackermann
2012-10-18 20:40 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy5j3ldj6.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
--cc=th.acker66@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox