From: Junio C Hamano <gitster@pobox.com>
To: Adam Spiers <git@adamspiers.org>
Cc: git list <git@vger.kernel.org>
Subject: Re: [PATCH] Improve legibility of test_expect_code output
Date: Wed, 19 Sep 2012 17:35:47 -0700 [thread overview]
Message-ID: <7vy5k5cyzg.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAOkDyE-x5NeZX2tpp3C9Kkwb1kPniHptB9ERvtpx2XODufaW=A@mail.gmail.com> (Adam Spiers's message of "Thu, 20 Sep 2012 01:25:51 +0100")
Adam Spiers <git@adamspiers.org> writes:
> On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Adam Spiers <git@adamspiers.org> writes:
>>
>>> ---
>>
>> No explanation why this is a good idea, nor sign-off?
>
> I realised I forgot the sign-off seconds after sending :-(
>
> Isn't it completely self-explanatory? e.g.
>
> test_expect_code: command exited with 0, we wanted 128 git foo bar
>
> clearly makes more sense than
>
> test_expect_code: command exited with 0, we wanted 128 from: git foo bar
If it were "..., we wanted 128 from 'git foo bar'", then I would,
but otherwise, not really.
next prev parent reply other threads:[~2012-09-20 0:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 22:38 [PATCH] Improve legibility of test_expect_code output Adam Spiers
2012-09-20 0:06 ` Junio C Hamano
2012-09-20 0:25 ` Adam Spiers
2012-09-20 0:35 ` Junio C Hamano [this message]
2012-09-20 0:48 ` Adam Spiers
2012-09-20 16:50 ` Junio C Hamano
2012-09-20 16:57 ` Adam Spiers
2012-09-20 17:45 ` Junio C Hamano
2012-09-20 18:05 ` Adam Spiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy5k5cyzg.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@adamspiers.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).