From: Junio C Hamano <gitster@pobox.com>
To: Clemens Buchacher <drizzd@aon.at>
Cc: git@vger.kernel.org, tobiasu@tmux.org
Subject: Re: [PATCH 3/3] push: old receive-pack does not understand --quiet
Date: Sun, 04 Sep 2011 19:28:38 -0700 [thread overview]
Message-ID: <7vy5y3yb6x.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1315067656-2846-4-git-send-email-drizzd@aon.at> (Clemens Buchacher's message of "Sat, 3 Sep 2011 18:34:16 +0200")
Clemens Buchacher <drizzd@aon.at> writes:
> @@ -114,7 +115,7 @@ static int show_ref(const char *path, const unsigned char *sha1, int flag, void
> else
> packet_write(1, "%s %s%c%s%s\n",
> sha1_to_hex(sha1), path, 0,
> - " report-status delete-refs side-band-64k",
> + " report-status delete-refs side-band-64k quiet",
> prefer_ofs_delta ? " ofs-delta" : "");
> sent_capabilities = 1;
> return 0;
> @@ -636,6 +637,8 @@ static struct command *read_head_info(void)
> report_status = 1;
> if (strstr(refname + reflen + 1, "side-band-64k"))
> use_sideband = LARGE_PACKET_MAX;
> + if (strstr(refname + reflen + 1, "quiet"))
> + quiet = 1;
Side note.
We may want to make sure that this is not part of a different token word
(if we knew better, we would have written the other side so that we can
just test against " quiet ", but that is not possible, sigh...).
> }
> cmd = xcalloc(1, sizeof(struct command) + len - 80);
> hashcpy(cmd->old_sha1, old_sha1);
> @@ -669,7 +672,7 @@ static const char *parse_pack_header(struct pack_header *hdr)
>
> static const char *pack_lockfile;
>
> -static const char *unpack(int quiet)
> +static const char *unpack()
I'll amend this as "static const char *unpack(void)" while applying.
next prev parent reply other threads:[~2011-09-05 2:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 10:57 [BUG] git push --quiet fails with older versions Tobias Ulmer
2011-09-03 16:34 ` Clemens Buchacher
2011-09-03 16:34 ` [PATCH 1/3] tests for push --quiet Clemens Buchacher
2011-09-03 16:34 ` [PATCH 2/3] fix push --quiet via http Clemens Buchacher
2011-09-03 16:34 ` [PATCH 3/3] push: old receive-pack does not understand --quiet Clemens Buchacher
2011-09-05 2:28 ` Junio C Hamano [this message]
2011-09-05 3:01 ` Junio C Hamano
2011-09-05 8:35 ` Junio C Hamano
2011-09-05 9:23 ` Michael J Gruber
2011-09-05 14:17 ` Michael J Gruber
2011-09-05 14:24 ` [PATCH] t5541: avoid TAP test miscounting Michael J Gruber
2011-09-05 19:34 ` [PATCH 3/3] push: old receive-pack does not understand --quiet Junio C Hamano
2011-09-06 6:03 ` Michael J Gruber
2011-09-06 18:01 ` Junio C Hamano
2011-09-06 19:52 ` Clemens Buchacher
2011-09-04 12:08 ` [BUG] git push --quiet fails with older versions Tobias Ulmer
2011-09-04 19:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy5y3yb6x.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=tobiasu@tmux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).