From: Junio C Hamano <gitster@pobox.com>
To: Fredrik Gustafsson <iveqy@iveqy.com>
Cc: git@vger.kernel.org, jens.lehmann@web.de, hvoigt@hvoigt.net
Subject: Re: [PATCH v2 3/3] push: Add the --no-recurse-submodules option
Date: Thu, 28 Jul 2011 13:05:45 -0700 [thread overview]
Message-ID: <7vy5zikw6e.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1311790250-32454-4-git-send-email-iveqy@iveqy.com> (Fredrik Gustafsson's message of "Wed, 27 Jul 2011 20:10:50 +0200")
Fredrik Gustafsson <iveqy@iveqy.com> writes:
> This adds the option --no-recurse-submodules to push. That is, git
I think this needs to be renamed at least for two reasons.
The name makes it sound as if "push --recurse-submodules" would
recursively visit the submodules and runs "push" there, but I do not think
that is what this flag does.
> diff --git a/transport.h b/transport.h
> index 161d724..c6ccf8c 100644
> --- a/transport.h
> +++ b/transport.h
> @@ -101,6 +101,7 @@ struct transport {
> #define TRANSPORT_PUSH_MIRROR 8
> #define TRANSPORT_PUSH_PORCELAIN 16
> #define TRANSPORT_PUSH_SET_UPSTREAM 32
> +#define TRANSPORT_PUSH_NO_RECURSE_SUBMODULES 64
Also naming the constant with NO will invite an unnecessary double
negation, like this:
if (!(flags & FROTZ_NO_NITFOL))
do_nitfol_to_frotz();
Besides, I would be moderately annoyed if this check were the default.
next prev parent reply other threads:[~2011-07-28 20:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 18:10 [PATCH v2 0/3] check for unpushed remotes in submodules Fredrik Gustafsson
2011-07-27 18:10 ` [PATCH v2 1/3] test whether push checks " Fredrik Gustafsson
2011-07-27 18:10 ` [PATCH v2 2/3] push: Don't push a repository with unpushed submodules Fredrik Gustafsson
2011-07-27 18:10 ` [PATCH v2 3/3] push: Add the --no-recurse-submodules option Fredrik Gustafsson
2011-07-28 20:05 ` Junio C Hamano [this message]
2011-07-28 22:22 ` Jens Lehmann
2011-07-29 20:19 ` Jens Lehmann
2011-08-01 1:16 ` Junio C Hamano
2011-07-28 19:58 ` [PATCH v2 0/3] check for unpushed remotes in submodules Junio C Hamano
2011-07-28 22:14 ` Jens Lehmann
-- strict thread matches above, loose matches on Subject: below --
2014-02-18 17:49 [PATCH v2 3/3] push: Add the --no-recurse-submodules option Semyon Perepelitsa
2014-02-20 13:12 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy5zikw6e.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=iveqy@iveqy.com \
--cc=jens.lehmann@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).