From: Junio C Hamano <gitster@pobox.com>
To: Pat Thoyts <patthoyts@users.sourceforge.net>
Cc: Tor Arvid Lund <torarvid@gmail.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] git-gui: support core.whitespace rules in diff view
Date: Wed, 20 Oct 2010 16:43:53 -0700 [thread overview]
Message-ID: <7vy69stop2.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <87pqv4fqqz.fsf_-_@fox.patthoyts.tk> (Pat Thoyts's message of "Wed\, 20 Oct 2010 23\:05\:43 +0100")
Pat Thoyts <patthoyts@users.sourceforge.net> writes:
> This is a rather more complete implementation of whitespace highlighting
> according to the core.whitespace setting. The diff view whitespace
> highlights should match what you see with 'git diff' when color is
> enabled for all the whitespace rules except cr-at-eol where there is
> currently a rule to hide these.
>
> Suggested-by: Tor Arvid Lund <torarvid@gmail.com>
> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
> ---
This might be a very stupid question, but isn't it an easier-to-maintain
option to let underlying "git diff" color its output and convert the ANSI
coloring to whatever Tcl wants to use, especially in the long run, instead
of trying to replicate the logic to check whitespace breakages here?
next prev parent reply other threads:[~2010-10-20 23:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 23:00 Colored whitespace in git gui Tor Arvid Lund
2010-10-19 22:59 ` [PATCH] git-gui: highlight trailing whitespace in diff view Pat Thoyts
2010-10-20 15:30 ` Tor Arvid Lund
2010-10-20 22:05 ` [PATCH] git-gui: support core.whitespace rules " Pat Thoyts
2010-10-20 23:43 ` Junio C Hamano [this message]
2010-10-21 12:36 ` Tor Arvid Lund
2010-10-21 18:58 ` Pat Thoyts
2010-10-22 12:00 ` Tor Arvid Lund
2010-10-22 15:18 ` Pat Thoyts
2010-10-21 15:22 ` [PATCH] git-gui: apply color information from git diff Pat Thoyts
2010-10-21 20:59 ` Kevin Ballard
2010-10-21 23:42 ` Pat Thoyts
2010-10-22 10:10 ` [PATCH] git-gui: apply color information from git diff output Pat Thoyts
2010-10-22 14:40 ` Tor Arvid Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy69stop2.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=patthoyts@users.sourceforge.net \
--cc=torarvid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).