From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 5/6] grep: add option -p/--show-function
Date: Wed, 01 Jul 2009 22:27:40 -0700 [thread overview]
Message-ID: <7vy6r7d583.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4A4C39D3.1020401@lsrfire.ath.cx> ("René Scharfe"'s message of "Thu\, 02 Jul 2009 06\:38\:43 +0200")
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
> Hmm, even shorter would be to leave out these "==" things entirely:
>
> # mock-up
> $ git grep -p -n markers grep.c
> grep.c=746=static void clr_hit_marker(struct grep_expr *x)
> grep.c:748: /* All-hit markers are meaningful only at...
> grep.c=760=static int chk_hit_marker(struct grep_expr *x)
> grep.c:762: /* Top level nodes have hit markers. See...
> grep.c=772=int grep_buffer(struct grep_opt *opt, const ch...
> grep.c:782: * We first clear hit markers from them.
>
> Is that still readable?
Actually the above matches what I expected to see when I read your [0/6].
Is the use of '=' your invention, or does somebody's grep have this
function header feature already and use '=' the same way?
next prev parent reply other threads:[~2009-07-02 5:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 22:00 [PATCH 0/6] grep: add option -p/--show-function, similar to diff's René Scharfe
2009-07-01 22:01 ` [PATCH 1/6] userdiff: add xdiff_clear_find_func() René Scharfe
2009-07-01 22:02 ` [PATCH 2/6] grep: move context hunk mark handling into show_line() René Scharfe
2009-07-01 22:55 ` Junio C Hamano
2009-07-02 3:15 ` René Scharfe
2009-07-02 5:24 ` Junio C Hamano
2009-07-01 22:03 ` [PATCH 3/6] grep: print context hunk marks between files René Scharfe
2009-07-01 22:05 ` [PATCH 4/6] grep: handle pre context lines on demand René Scharfe
2009-07-01 22:06 ` [PATCH 5/6] grep: add option -p/--show-function René Scharfe
2009-07-02 2:35 ` Junio C Hamano
2009-07-02 4:38 ` René Scharfe
2009-07-02 5:27 ` Junio C Hamano [this message]
2009-07-02 6:16 ` René Scharfe
2009-07-02 15:42 ` René Scharfe
2009-07-01 22:07 ` [PATCH 6/6] grep -p: support user defined regular expressions René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy6r7d583.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).