From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder@fzi.de>
Cc: "Johannes Sixt" <j.sixt@viscovery.net>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"SZEDER Gábor" <szeder@ira.uka.de>,
git@vger.kernel.org
Subject: Re: [RFC PATCH] Fix gitdir detection when in subdir of gitdir
Date: Sun, 18 Jan 2009 19:15:03 -0800 [thread overview]
Message-ID: <7vy6x8rnpk.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090119020311.GA8753@neumann> (SZEDER Gábor's message of "Mon, 19 Jan 2009 03:03:11 +0100")
SZEDER Gábor <szeder@fzi.de> writes:
> Thanks. In the meantime I was working on a patch that sets relative
> path in this case, too.
Does it make sense to use relative path in such a case?
If it is for "rev-parse --git-dir", the calling script may learn the
correct location of the GIT_DIR with either relative or absolute, but if
it is for the internal consumption of git process itself and any
subprocess forked from us that look at GIT_DIR we export, the process
already runs at the repository root (because you do not chdir back) and
using relative path does not make much sense. Exported GIT_DIR has to be
either "." or the full path from the root to make sense to such a user, I
think.
next prev parent reply other threads:[~2009-01-19 3:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 15:37 [RFC PATCH] Fix gitdir detection when in subdir of gitdir SZEDER Gábor
2009-01-16 16:29 ` Johannes Schindelin
2009-01-16 16:47 ` Johannes Sixt
2009-01-16 16:50 ` Johannes Sixt
2009-01-16 17:23 ` SZEDER Gábor
2009-01-16 18:07 ` Junio C Hamano
2009-01-16 20:55 ` Johannes Schindelin
2009-01-18 21:27 ` Junio C Hamano
2009-01-19 2:03 ` SZEDER Gábor
2009-01-19 3:15 ` Junio C Hamano [this message]
2009-01-19 7:17 ` Johannes Sixt
2009-01-19 2:08 ` [PATCH] t1500: extend with tests of 'git rev-parse --git-dir' SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy6x8rnpk.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=szeder@fzi.de \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).