git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Mike Coleman" <tutufan@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git-diff should not fire up $PAGER, period!
Date: Wed, 17 Dec 2008 18:26:09 -0800	[thread overview]
Message-ID: <7vy6yei5ha.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <3c6c07c20812171818k6b6e3555ja991e20d74d8291b@mail.gmail.com> (Mike Coleman's message of "Wed, 17 Dec 2008 20:18:38 -0600")

"Mike Coleman" <tutufan@gmail.com> writes:

> To me, the most important nugget from the original complaint was that
> git-diff sends its error messages to stdout.  I understand why it
> might be done, but I'd worry about losing the stderr diagnostic for a
> command that matters.  [I've been playing around with this for a few
> minutes trying to see errors going to stdout and I can't reproduce
> it--I wonder if they really do.]

They indeed did but it has hopefully been fixed.  See a833502 (pager: do
not dup2 stderr if it is already redirected, 2008-12-15).

> ...  Like Junio, I also eschew doing terminal emulation
> inside of emacs.

Come to think of it, it may have been from you that I picked up the trick
of setting PAGER to cat inside an Emacs environment.

> Good evening from the icy midwest,

Good evening from rainy and chilly SoCal.

  reply	other threads:[~2008-12-18  2:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-18  2:18 git-diff should not fire up $PAGER, period! Mike Coleman
2008-12-18  2:26 ` Junio C Hamano [this message]
2008-12-18  3:22 ` Johannes Schindelin
  -- strict thread matches above, loose matches on Subject: below --
2008-12-16  0:56 git-diff should not fire up $PAGER if there is no diff Jeff King
2008-12-17 21:45 ` git-diff should not fire up $PAGER, period! jidanni
2008-12-17 22:02   ` Junio C Hamano
2008-12-17 22:04   ` Linus Torvalds
2008-12-22  3:28     ` Miles Bader
2008-12-18  3:31   ` Jeff King
2008-12-22  3:27   ` Miles Bader
2008-12-22  7:55     ` Johannes Sixt
2008-12-22  8:30       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vy6yei5ha.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=tutufan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).