git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Trent Piepho <tpiepho@freescale.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] send-email: Fix Pine address book parsing
Date: Tue, 25 Nov 2008 22:44:46 -0800	[thread overview]
Message-ID: <7vy6z7gf4x.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0811252137250.5161@t2.domain.actdsltmp> (Trent Piepho's message of "Tue, 25 Nov 2008 21:59:45 -0800 (PST)")

Trent Piepho <tpiepho@freescale.com> writes:

> The tech docs I linked to just say pine continues lines with leading space,
> but not how many spaces exactly.

My reading of the wording "spaces" it uses is that any number.  I agree it
is underspecified what would happen to them.

> It also appears to only split lines between whitespace and
> non-whitespace. ...
> ... like "a b \n   c \n   d\n".  If I didn't eat the leading spaces in the
> continuations, it would be re-assembled as "a b    c    d".  This might cause
> an address to become "John     Doe <jdoe@anon.org>"

Which would still work.  If you had two addresses a and b and smashed them
together into ab on the other hand it wouldn't.  That is why I asked.

If you know for sure (e.g. by reading the Pine source) that it only splits
a line at a whitespace to non-whitespace transition, that it keeps the
whitespace at the end of the first line, and that the non-whitespace and
everything after that on the second line (prefixed by extra unspecified
number of spaces as the continuation sign), then I think what you had in
your patch is exactly what we want.  I just wanted to make sure you know
what you are doing, as I do not use Pine nor its address book myself.

  reply	other threads:[~2008-11-26  6:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-26  2:55 [PATCH] send-email: Fix Pine address book parsing Trent Piepho
2008-11-26  4:58 ` Junio C Hamano
2008-11-26  5:59   ` Trent Piepho
2008-11-26  6:44     ` Junio C Hamano [this message]
2008-11-26 11:13       ` Trent Piepho
2008-11-26 19:46         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vy6z7gf4x.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=tpiepho@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).