From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] Avoid using non-portable `echo -n` in tests. Date: Fri, 31 Oct 2008 01:15:51 -0700 Message-ID: <7vy70589jc.fsf@gitster.siamese.dyndns.org> References: <8A4A84EC-51F7-4038-957C-CCA5C00E5977@silverinsanity.com> <1225429753-70109-1-git-send-email-benji@silverinsanity.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Git List , Shawn O Pearce To: Brian Gernhardt X-From: git-owner@vger.kernel.org Fri Oct 31 09:17:26 2008 connect(): Connection refused Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1KvpC9-0006Tu-HS for gcvg-git-2@gmane.org; Fri, 31 Oct 2008 09:17:26 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752918AbYJaIQL (ORCPT ); Fri, 31 Oct 2008 04:16:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752856AbYJaIQL (ORCPT ); Fri, 31 Oct 2008 04:16:11 -0400 Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:53955 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758AbYJaIQK (ORCPT ); Fri, 31 Oct 2008 04:16:10 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 4C94877250; Fri, 31 Oct 2008 04:16:09 -0400 (EDT) Received: from pobox.com (ip68-225-240-211.oc.oc.cox.net [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTPSA id 4D26C77244; Fri, 31 Oct 2008 04:15:58 -0400 (EDT) In-Reply-To: <1225429753-70109-1-git-send-email-benji@silverinsanity.com> (Brian Gernhardt's message of "Fri, 31 Oct 2008 01:09:13 -0400") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Pobox-Relay-ID: 2C30542C-A724-11DD-8919-9CEDC82D7133-77302942!a-sasl-fastnet.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Brian Gernhardt writes: > Not all /bin/sh have a builtin echo that recognizes -n. Using printf > is far more portable. This is much better (minor nit: we do not care if echo is built-in or /bin/echo); the point of t4030 is to produce an incomplete line ;-). Will queue, thanks.