From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] test-lib: do not remove trash_directory if called with
 --debug
Date: Thu, 21 Aug 2008 01:52:31 -0700
Message-ID: <7vy72qiwc0.fsf@gitster.siamese.dyndns.org>
References: <7vabf7mcpz.fsf@gitster.siamese.dyndns.org>
 <20080821011811.GA13915@coredump.intra.peff.net>
 <alpine.DEB.1.00.0808210946280.24820@pacific.mpi-cbg.de.mpi-cbg.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
X-From: git-owner@vger.kernel.org Thu Aug 21 10:53:49 2008
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1KW5vO-0004mR-Ek
	for gcvg-git-2@gmane.org; Thu, 21 Aug 2008 10:53:46 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752851AbYHUIwk (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Thu, 21 Aug 2008 04:52:40 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753083AbYHUIwk
	(ORCPT <rfc822;git-outgoing>); Thu, 21 Aug 2008 04:52:40 -0400
Received: from a-sasl-quonix.sasl.smtp.pobox.com ([208.72.237.25]:61414 "EHLO
	sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751618AbYHUIwj (ORCPT <rfc822;git@vger.kernel.org>);
	Thu, 21 Aug 2008 04:52:39 -0400
Received: from localhost.localdomain (localhost [127.0.0.1])
	by a-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTP id 71FFE62380;
	Thu, 21 Aug 2008 04:52:37 -0400 (EDT)
Received: from pobox.com (ip68-225-240-211.oc.oc.cox.net [68.225.240.211])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client
 certificate requested) by a-sasl-quonix.sasl.smtp.pobox.com (Postfix) with
 ESMTPSA id 9B5B66237F; Thu, 21 Aug 2008 04:52:33 -0400 (EDT)
In-Reply-To: <alpine.DEB.1.00.0808210946280.24820@pacific.mpi-cbg.de.mpi-cbg.de> (Johannes
 Schindelin's message of "Thu, 21 Aug 2008 09:49:12 +0200 (CEST)")
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
X-Pobox-Relay-ID: 811A13E0-6F5E-11DD-9945-3113EBD4C077-77302942!a-sasl-quonix.pobox.com
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/93125>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Sometimes you want to keep the trash directory, even if all tests
> passed.  For example, when extending tests, it comes it quite handy.

Yeah, I think hooking this with --debug is makes actual sense.  Much saner
than changing the behaviour magically with "make -j".

Even though I personally do not particularly like having an _easy_ way to
leave the cruft around, I'll apply it if Jeff and other people like this
behaviour.