From: Junio C Hamano <gitster@pobox.com>
To: "Giovanni Funchal" <gafunchal@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Patch for NO_R_TO_GCC_LINKER
Date: Wed, 13 Aug 2008 13:10:51 -0700 [thread overview]
Message-ID: <7vy730n0ac.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <c475e2e60808130342r452fae1cm7d08d8d2206d0468@mail.gmail.com> (Giovanni Funchal's message of "Wed, 13 Aug 2008 12:42:30 +0200")
"Giovanni Funchal" <gafunchal@gmail.com> writes:
> diff --git a/Makefile b/Makefile
> index 90c5a13..6e20b08 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -111,9 +111,8 @@ all::
> #
> # Define NO_DEFLATE_BOUND if your zlib does not have deflateBound.
> #
> -# Define NO_R_TO_GCC_LINKER if your gcc does not like "-R/path/lib"
> -# that tells runtime paths to dynamic libraries;
> -# "-Wl,-rpath=/path/lib" is used instead.
> +# LD_RUNPATH_SWITCH specifies how to pass the runtime dynamic library paths
> +# to the linker. The default is "-Wl,-rpath,".
Can you make your change to configure.ac to minimize changes to the
Makefile?
In this project, use of configure is strictly optional and Makefile is
more canonical than autoconf generated configure. Unless absolutely
necessary, I'd prefer to have a solution that does _not_ change the set of
make variables people need to override from the command line.
Changes to configure.ac so that generated script sets NO_R_TO_GCC_LINKER
appropriately would fit the current model much better and would not break
people's existing setups that do not use configure.
next prev parent reply other threads:[~2008-08-13 20:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 10:42 Patch for NO_R_TO_GCC_LINKER Giovanni Funchal
2008-08-13 11:32 ` Matthieu Moy
2008-08-13 20:10 ` Junio C Hamano [this message]
2008-08-13 21:20 ` Giovanni Funchal
2008-08-13 21:50 ` Junio C Hamano
2008-08-13 22:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy730n0ac.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=gafunchal@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).