From: Junio C Hamano <gitster@pobox.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: Git ML <git@vger.kernel.org>
Subject: Re: THREADED_DELTA_SEARCH
Date: Thu, 10 Jul 2008 08:34:45 -0700 [thread overview]
Message-ID: <7vy749pxbe.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080710075327.GD24819@artemis.madism.org> (Pierre Habouzit's message of "Thu, 10 Jul 2008 09:53:27 +0200")
Pierre Habouzit <madcoder@debian.org> writes:
> I'm using it in production for quite a long time now, and I wonder if
> there is any specific reason why it's not default. Debian activated it
> by default too a couple of weeks ago, which means that it's in
> production on quite a large scale, and there are no issues reported
> either. Would a patch making it default be accepted ? It's quite handy
> given that SMP machines are really pervasive nowadays…
There were two issues, IIRC.
(1) resulting pack could be suboptimal, due to delta-chain getting cut
betweeen the worker thread boundary.
(2) exploding memory use, suspected to be due to malloc pool
fragmentation under multithreading.
The former was only an issue with early iterations of the code and the
current code has much improved behaviour on this point, but I do not
recall the latter issue has been addressed.
next prev parent reply other threads:[~2008-07-10 15:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 7:53 THREADED_DELTA_SEARCH Pierre Habouzit
2008-07-10 8:01 ` THREADED_DELTA_SEARCH Johannes Sixt
2008-07-10 16:50 ` THREADED_DELTA_SEARCH Andreas Ericsson
2008-07-10 8:51 ` THREADED_DELTA_SEARCH Jakub Narebski
2008-07-10 9:33 ` THREADED_DELTA_SEARCH Pierre Habouzit
2008-07-10 15:34 ` Junio C Hamano [this message]
2008-07-10 16:21 ` THREADED_DELTA_SEARCH Nicolas Pitre
2008-07-10 20:13 ` THREADED_DELTA_SEARCH Alex Riesen
2008-07-10 20:26 ` THREADED_DELTA_SEARCH Nicolas Pitre
2008-07-10 20:29 ` THREADED_DELTA_SEARCH Alex Riesen
2008-07-10 20:36 ` THREADED_DELTA_SEARCH Nicolas Pitre
2008-07-10 22:19 ` THREADED_DELTA_SEARCH Alex Riesen
[not found] ` <alpine.DEB.1.00.0807110032030.3279@eeepc-johanness>
[not found] ` <alpine.LFD.1.10.0807101851520.12484@xanadu.home>
[not found] ` <81b0412b0807102259q1046051bwc513eadb50847675@mail.gmail.com>
2008-07-11 7:41 ` THREADED_DELTA_SEARCH Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy749pxbe.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).