git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Boyd Lynn Gerber <gerberb@zenez.com>
Cc: Daniel Barkalow <barkalow@iabervon.org>,
	Thomas Harning <harningt@gmail.com>,
	Jeremy Maitin-Shepard <jbms@cmu.edu>,
	Git List <git@vger.kernel.org>
Subject: Re: [PATCH] 0003 This patch is to allow 12 different OS's to compile and run git.
Date: Sun, 08 Jun 2008 00:45:33 -0700	[thread overview]
Message-ID: <7vy75gl68y.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: Pine.LNX.4.64.0806072143230.18454@xenau.zenez.com

Boyd Lynn Gerber <gerberb@zenez.com> writes:

> So I should have
> ... (deleted)

More like this:

    From: Boyd Lynn Gerber <gerberb@zenez.com>
    Subject: [PATCH] Port to other 12 platforms
    Date: Sat, 7 Jun 2008 21:46:48 -0600
    To: git@vger.kernel.org
    Cc: gitster@pobox.com

    This adds support to compile git on 12 platforms (<<whichever one you
    ported including UnixWare, SCO,... are listed here.>>).

    __USLC__ indicates UNIX System Labs Corperation (USLC), or a 
    Novell-derived compiler and/or some SysV based OS's.  __M_UNIX indicates
    XENIX/SCO UNIX/OpenServer before 5.0.7 and prior  release of and SCO OS.
    Like Apple and BSD, both of these do not want _XOPEN_SOURCE defined to
    allow use of <<the symbols that is hidden if you have _XOPEN_SOURCE
    defined>>.

    Signed-off-by: Boyd Lynn Gerber <gerberb@zenez.com>
    ---
    << "git diff --stat -p" output for the patch here >>

without removal of dynamic-sized array from progress.c, which is not really
part of specific port to these 12 platforms, but is a more generic
"portability fix", which might read like this:

    From: Boyd Lynn Gerber <gerberb@zenez.com>
    Subject: [PATCH] progress.c: avoid use of dynamic-sized array
    Date: Sat, 7 Jun 2008 21:46:48 -0600
    To: git@vger.kernel.org
    Cc: gitster@pobox.com

    Dynamically sized arrays are gcc and C99 construct.  It sometimes is
    nice to use them but hurts portability to older compilers.  This
    removes the only use of the construct in stop_progress_msg(); the
    function is about writing out a single line of message, and the
    existing callers of this function feed messages of only bounded size
    anyway, so use of dynamic array is simply overkill.

    Signed-off-by: Boyd Lynn Gerber <gerberb@zenez.com>
    ---
    << "git diff --stat -p" output for the patch here >>

  reply	other threads:[~2008-06-08  7:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06 19:34 [PATCH] This patch is to allow 12 different OS's to compile and run git Boyd Lynn Gerber
2008-06-06 19:39 ` Jeremy Maitin-Shepard
2008-06-06 20:02   ` Boyd Lynn Gerber
2008-06-06 20:15     ` Stephan Beyer
2008-06-06 20:28       ` Linus Torvalds
2008-06-06 20:44         ` Boyd Lynn Gerber
2008-06-06 22:16     ` Brandon Casey
2008-06-06 23:08     ` Junio C Hamano
2008-06-06 23:23       ` Boyd Lynn Gerber
2008-06-07  0:38         ` [PATCH] 0002 " Boyd Lynn Gerber
2008-06-07  0:47           ` Daniel Barkalow
2008-06-07  1:25             ` [PATCH] 0003 " Boyd Lynn Gerber
2008-06-07  2:12               ` Junio C Hamano
2008-06-07  2:40                 ` Boyd Lynn Gerber
2008-06-07  3:40                   ` Daniel Barkalow
2008-06-08  3:46                     ` Boyd Lynn Gerber
2008-06-08  7:45                       ` Junio C Hamano [this message]
2008-06-08 16:57                         ` [PATCH] progress.c: avoid use of dynamic-sized array Boyd Lynn Gerber
2008-06-08 17:07                         ` [PATCH] Port to 12 other Platforms Boyd Lynn Gerber
2008-06-08  3:50                     ` [PATCH] 0004 This patch is to allow 12 different OS's to compile and run git Boyd Lynn Gerber
2008-06-08  7:22                       ` Boyd Lynn Gerber
2008-06-06 19:46 ` [PATCH] " Thomas Harning
2008-06-06 22:58 ` Daniel Barkalow
2008-06-06 23:17   ` Boyd Lynn Gerber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vy75gl68y.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=barkalow@iabervon.org \
    --cc=gerberb@zenez.com \
    --cc=git@vger.kernel.org \
    --cc=harningt@gmail.com \
    --cc=jbms@cmu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).