git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Stephan Beyer <s-beyer@gmx.net>, Jaroslav Kysela <perex@perex.cz>,
	git@vger.kernel.org
Subject: Re: [PATCH] Keep committer and committer dates
Date: Wed, 04 Jun 2008 22:03:17 -0700	[thread overview]
Message-ID: <7vy75k4goa.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0806050523120.21190@racer> (Johannes Schindelin's message of "Thu, 5 Jun 2008 05:25:02 +0100 (BST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Of course it is possible!  I even pointed to a method!
>
> The _point_ was that we do not want to recommend it.  And giving prominent 
> support for it, such as introducing a command line parameter, _would_ 
> have the effect of recommending it.

The world is no black and white, but here are some guidelines to think
about this issue:

 - We need to be able to lie when we are importing from a foreign SCM.  We
   want to get identical import if two different people imported from
   exactly the same foreign history at two different times.  Obviously
   recording the person as the committer who happened to run the import
   does not work here.

 - When we are mechanically filtering a history (e.g. filter-branch
   --subdirectory-filter), the point of the rewrite is not about
   reorganizing the commits but tidying up the history.  We would most
   likely want to keep the committer here, too.

 - We encourage private history to be tidied up before publishing by
   giving flexible ways to cherry-pick and rebase.  On the other hand, we
   very strongly discourage rebasing other people's commits.  If you are
   rebasing your own commits, there is no need to lie.

  reply	other threads:[~2008-06-05  5:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-03 14:59 [PATCH] Keep committer and committer dates Jaroslav Kysela
2008-06-03 20:16 ` Johannes Schindelin
2008-06-04  9:16   ` Jaroslav Kysela
2008-06-04 10:29     ` Karl Hasselström
2008-06-04 11:12       ` Jakub Narebski
2008-06-04 12:29         ` Jaroslav Kysela
2008-06-04 14:22           ` Nicolas Pitre
2008-06-04 15:43           ` Johannes Schindelin
2008-06-05  1:03             ` Stephan Beyer
2008-06-05  4:25               ` Johannes Schindelin
2008-06-05  5:03                 ` Junio C Hamano [this message]
2008-06-05  7:10                 ` Johannes Sixt
2008-06-05 12:44                   ` Jaroslav Kysela
2008-06-05 13:13                     ` Johannes Schindelin
2008-06-05 13:38                       ` Jaroslav Kysela
2008-06-05 13:54                         ` Johannes Schindelin
2008-06-05 14:11                           ` Jaroslav Kysela
2008-06-05 14:46                             ` Johannes Schindelin
2008-06-05 15:16                               ` Jaroslav Kysela
2008-06-05 16:34                                 ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vy75k4goa.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=s-beyer@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).