From: Junio C Hamano <gitster@pobox.com>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: Carlos Rica <jasampler@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] mktag.c: tweak validation of tagger field and adjust test script
Date: Mon, 31 Mar 2008 22:39:35 -0700 [thread overview]
Message-ID: <7vy77ygmlk.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <47F172E3.7010104@nrlssc.navy.mil> (Brandon Casey's message of "Mon, 31 Mar 2008 18:25:23 -0500")
Brandon Casey <casey@nrlssc.navy.mil> writes:
> /*
> * Check for correct form for name and email
> * i.e. " <" followed by "> " on _this_ line
> + * No angle brackets within the name or email address fields.
> + * No spaces within the email address field.
> */
> tagger_line += 7;
> if (!(lb = strstr(tagger_line, " <")) || !(rb = strstr(lb+2, "> ")) ||
> + strpbrk(tagger_line, "<>\n") != lb+1 ||
> + strpbrk(lb+2, "><\n ") != rb)
> + return error("char" PD_FMT ": malformed tagger field",
> tagger_line - buffer);
This is the first use of strpbrk() in git.git codebase. Are BSD folks Ok
with it (I understand this came from SVID 1, just like strspn we already
use elsewhere)?
prev parent reply other threads:[~2008-04-01 5:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1206490795-13247-1-git-send-email-casey@nrlssc.navy.mil>
2008-03-26 0:40 ` [PATCH] mktag.c: improve verification of tagger field and tests Brandon Casey
2008-03-26 0:44 ` Brandon Casey
2008-03-26 11:21 ` Carlos Rica
2008-03-26 16:26 ` Brandon Casey
2008-03-26 16:37 ` Brandon Casey
2008-03-26 16:45 ` Junio C Hamano
2008-03-26 21:03 ` Brandon Casey
2008-03-27 16:16 ` [PATCH v2] " Brandon Casey
2008-03-31 8:40 ` Junio C Hamano
2008-03-31 16:04 ` Brandon Casey
2008-03-31 23:25 ` [PATCH] mktag.c: tweak validation of tagger field and adjust test script Brandon Casey
2008-04-01 5:39 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy77ygmlk.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=jasampler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).