From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] "git push": tellme-more protocol extension
Date: Thu, 20 Mar 2008 21:24:18 -0700 [thread overview]
Message-ID: <7vy78cu2kt.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080321023303.GE1613@coredump.intra.peff.net> (Jeff King's message of "Thu, 20 Mar 2008 22:33:03 -0400")
Jeff King <peff@peff.net> writes:
> 2. This can actually be _more_ network intensive than your proposal.
I do not think this matters much in practice. If you have tons of refs on
_your_ side to matter, some of them would be tags that are known to both
ends. The only case it really is troublesome is when the sender does not
know _any_ of the refs the receiver presented to it.
In the illustration in the message you are responding to, if the commit A
was tagged at the shared repository when two developers cloned, it does
not matter if C is unknown to the second pusher.
So a potential improvement might be to ask for "tellme-more" only if we do
not know any of the refs the receiver showed us; my patch does it if there
is at least one unknown instead.
next prev parent reply other threads:[~2008-03-21 4:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 7:58 [PATCH] "git push": tellme-more protocol extension Junio C Hamano
2008-03-21 2:33 ` Jeff King
2008-03-21 4:24 ` Junio C Hamano [this message]
2008-03-21 4:28 ` Jeff King
2008-03-21 4:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy78cu2kt.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).