git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH-v4 4/4] git-commit: add a prepare-commit-msg hook
Date: Wed, 06 Feb 2008 01:08:00 -0800	[thread overview]
Message-ID: <7vy79y1mhb.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <E1JMfN3-0006XI-Qs@fencepost.gnu.org> (Paolo Bonzini's message of "Tue, 5 Feb 2008 08:04:18 +0100")

Paolo Bonzini <bonzini@gnu.org> writes:

> 	The way it can be used instead of the pre-commit hook
> 	is now documented differently: it is for verification
> 	that must *not* be skipped even for automatic commits
> 	(if there is such a beast).

I really do not think we should encourage this as a verification
method.  If you encourage it as such, I am sure people would
complain "Why can't I bypass this hook with --no-verify!!!".
I do not want to spend cycles defending the behaviour to error
out on non-zero exit from the hook.

Instead, I think you should _stress_ that people must _NOT_ use
this as a replacement for pre-commit hook.

The same comment applies to the comment in the example hook.

  reply	other threads:[~2008-02-06  9:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06  6:50 [PATCH-v3 4/4] git-commit: add a prepare-commit-msg hook Paolo Bonzini
2008-02-06  7:22 ` Junio C Hamano
2008-02-05  7:04   ` [PATCH-v4 " Paolo Bonzini
2008-02-06  9:08     ` Junio C Hamano [this message]
2008-02-05  7:04       ` [PATCH-v5 " Paolo Bonzini
2008-02-06 10:58         ` Junio C Hamano
2008-02-06 11:34           ` [PATCH-v6 " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vy79y1mhb.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=bonzini@gnu.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).