From: Junio C Hamano <gitster@pobox.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Christian Stimming <stimming@tuhh.de>, git@vger.kernel.org
Subject: Re: [PATCH] gitk: Update and fix Makefile
Date: Wed, 09 Jan 2008 00:19:35 -0800 [thread overview]
Message-ID: <7vy7azl8bs.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 18308.17099.334609.80415@cargo.ozlabs.ibm.com
Paul Mackerras <paulus@samba.org> writes:
> Junio C Hamano writes:
>
>> I see somwhat funny spacing there. I'd suggest giving up
>> aligning with spaces and consistently saying "var ?= val"
>> instead.
>
> I made those lines all have one space before and after the ?=, and
> committed Christian's patches (plus one from Gerrit Pape), and pushed
> it out. Please do a pull.
There were a couple of things I noticed that made me somewhat curious:
* There are more spaces around ?= in Christian's patch to Makefile.
* You have two patches from Christian and one patch from
Gerrit; the author and commit timestamps of these commits are
the same and in your timezone.
but nothing to complain about. Pulled and pushed out.
next prev parent reply other threads:[~2008-01-09 8:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 20:54 [PATCH] gitk: Update and fix Makefile Christian Stimming
2008-01-08 22:54 ` Junio C Hamano
2008-01-09 3:43 ` Paul Mackerras
2008-01-09 8:19 ` Junio C Hamano [this message]
2008-01-11 8:57 ` Junio C Hamano
2008-01-11 9:06 ` Junio C Hamano
2008-01-11 23:36 ` Paul Mackerras
2008-01-11 23:57 ` Junio C Hamano
2008-01-12 5:04 ` Jeff King
2008-01-13 21:06 ` [PATCH] gitk: Update and fix Makefile (spelling fix) Christian Stimming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy7azl8bs.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
--cc=stimming@tuhh.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).