From: Junio C Hamano <gitster@pobox.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-tag: fix -l switch handling regression.
Date: Sat, 22 Dec 2007 00:01:23 -0800 [thread overview]
Message-ID: <7vy7bnyx7w.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071221211833.GA10318@artemis.madism.org> (Pierre Habouzit's message of "Fri, 21 Dec 2007 22:18:33 +0100")
Pierre Habouzit <madcoder@debian.org> writes:
> On Fri, Dec 21, 2007 at 04:32:43PM +0000, Junio C Hamano wrote:
> ...
>> I thought this depended on some other changes. As is, doesn't
>> it break the t7004 test?
>
> Well there are tests that test:
>
> git tag -n xxx -l ...
>
> or
>
> git tag -n "" -l ...
>
> but I think we agreed those test nothing legitimate, and that the
> tests have to be removed. SO yes it hides another patch to cleanse t7004
> from the broken tests.
Thanks for a clarification; I'll resurect parts of my test
fix-ups and squash that in.
next prev parent reply other threads:[~2007-12-22 8:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 0:32 1.5.4-rc2 plans Junio C Hamano
2007-12-21 7:26 ` Johannes Sixt
2007-12-21 9:09 ` Mike Frysinger
2007-12-22 15:04 ` Johannes Schindelin
2007-12-22 17:54 ` Mike Frysinger
2007-12-21 8:57 ` Steven Grimm
2007-12-21 10:47 ` Pierre Habouzit
2007-12-21 10:50 ` [PATCH] git-tag: fix -l switch handling regression Pierre Habouzit
2007-12-21 16:32 ` Junio C Hamano
2007-12-21 21:18 ` Pierre Habouzit
2007-12-22 8:01 ` Junio C Hamano [this message]
2007-12-21 11:06 ` 1.5.4-rc2 plans Junio C Hamano
2007-12-21 11:13 ` Pierre Habouzit
2007-12-21 11:19 ` [PATCH] parse-options: Add a gitcli(5) man page Pierre Habouzit
2007-12-22 15:05 ` 1.5.4-rc2 plans Johannes Schindelin
2007-12-22 17:03 ` Pierre Habouzit
2007-12-22 17:16 ` Junio C Hamano
2007-12-22 17:38 ` Pierre Habouzit
2007-12-22 17:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy7bnyx7w.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).