From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] Fix Solaris Workshop Compiler issues Date: Wed, 14 Nov 2007 16:46:20 -0800 Message-ID: <7vy7d08her.fsf@gitster.siamese.dyndns.org> References: <20071114204732.GE3973@steel.home> <7vprycfrk6.fsf@gitster.siamese.dyndns.org> <20071114232809.GH3973@steel.home> <20071115001756.GA25021@atjola.homenet> <7v3av89wq7.fsf@gitster.siamese.dyndns.org> <20071115004404.GB25021@atjola.homenet> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Alex Riesen , Guido Ostkamp , git@vger.kernel.org To: =?utf-8?Q?Bj=C3=B6rn?= Steinbrink X-From: git-owner@vger.kernel.org Thu Nov 15 01:46:46 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IsSsY-0006PM-2z for gcvg-git-2@gmane.org; Thu, 15 Nov 2007 01:46:46 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756762AbXKOAq3 convert rfc822-to-quoted-printable (ORCPT ); Wed, 14 Nov 2007 19:46:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755271AbXKOAq3 (ORCPT ); Wed, 14 Nov 2007 19:46:29 -0500 Received: from sceptre.pobox.com ([207.106.133.20]:40840 "EHLO sceptre.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965AbXKOAq2 convert rfc822-to-8bit (ORCPT ); Wed, 14 Nov 2007 19:46:28 -0500 Received: from sceptre (localhost.localdomain [127.0.0.1]) by sceptre.pobox.com (Postfix) with ESMTP id 90DFF2F0; Wed, 14 Nov 2007 19:46:49 -0500 (EST) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by sceptre.sasl.smtp.pobox.com (Postfix) with ESMTP id 0B12A95DA3; Wed, 14 Nov 2007 19:46:44 -0500 (EST) In-Reply-To: <20071115004404.GB25021@atjola.homenet> (=?utf-8?Q?Bj=C3=B6rn?= Steinbrink's message of "Thu, 15 Nov 2007 01:44:04 +0100") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Bj=C3=B6rn Steinbrink writes: > On 2007.11.14 16:30:08 -0800, Junio C Hamano wrote: > >> Maybe your compiler needs -DFLEX_ARRAY=3D0 in CFLAGS? > > Actually, I just created a test-case remotely on a Solaris box in my > university (see below) and didn't compile the actual git code. With t= he > FAM, cc complains about a redeclared identifier, with a zero-sized > array, it complains that an array cannot be zero-sized... I think you can pass -DFLEX_ARRAY=3D1 as a workaround. It would waste one array member in a flexible structure but that is better than compiler choking.