From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] git-sh-setup.sh: make GIT_EDITOR/core.editor/VISUAL/EDITOR accept commands Date: Wed, 01 Aug 2007 16:18:14 -0700 Message-ID: <7vy7gu3kuh.fsf@assigned-by-dhcp.cox.net> References: <7v7iof3uc5.fsf@assigned-by-dhcp.cox.net> <85ejimrjb2.fsf@lola.goethe.zz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org To: David Kastrup X-From: git-owner@vger.kernel.org Thu Aug 02 01:18:22 2007 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IGNSO-0003Rr-SY for gcvg-git@gmane.org; Thu, 02 Aug 2007 01:18:21 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750929AbXHAXSQ (ORCPT ); Wed, 1 Aug 2007 19:18:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751403AbXHAXSQ (ORCPT ); Wed, 1 Aug 2007 19:18:16 -0400 Received: from fed1rmmtao107.cox.net ([68.230.241.39]:61089 "EHLO fed1rmmtao107.cox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750929AbXHAXSP (ORCPT ); Wed, 1 Aug 2007 19:18:15 -0400 Received: from fed1rmimpo02.cox.net ([70.169.32.72]) by fed1rmmtao107.cox.net (InterMail vM.7.08.02.01 201-2186-121-102-20070209) with ESMTP id <20070801231814.BNRY7349.fed1rmmtao107.cox.net@fed1rmimpo02.cox.net>; Wed, 1 Aug 2007 19:18:14 -0400 Received: from assigned-by-dhcp.cox.net ([68.5.247.80]) by fed1rmimpo02.cox.net with bizsmtp id WnJE1X00U1kojtg0000000; Wed, 01 Aug 2007 19:18:15 -0400 In-Reply-To: <85ejimrjb2.fsf@lola.goethe.zz> (David Kastrup's message of "Thu, 02 Aug 2007 00:17:37 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: David Kastrup writes: > David Kastrup writes: > >> The previous code only allowed specifying a single executable rather >> than a complete command like "emacsclient --alternate-editor vi" in > > Oops, won't apply cleanly. I found that I had already made a > different (trivial) patch previously. Let me try again and fold that > patch in manually. It is not just "won't apply". What if GIT_DIR had spaces (which is fine) and single-quotes in it? Wouldn't it percolate down to $@ because it becomes the leading directory of the temporary file name? And you quote '"$@"' and eval it, now what happens?