From: Junio C Hamano <junkio@cox.net>
To: git@vger.kernel.org
Cc: Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] dir: do all size checks before seeking back and fix file closing
Date: Sat, 26 Aug 2006 20:04:18 -0700 [thread overview]
Message-ID: <7vy7tayj4d.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0608261931460.11811@g5.osdl.org> (Linus Torvalds's message of "Sat, 26 Aug 2006 19:37:57 -0700 (PDT)")
Linus Torvalds <torvalds@osdl.org> writes:
>> The comparison order is done in textual order. You list smaller
>> things on the left and then larger things on the right (iow, you
>> almost never use >= or >).
>
> Ahh. A number of people do the "0 == x" thing, because they want to be
> caught if they use "=" instead of "==" by mistake. I thought it was the
> same thing.
The rest is repeating what you said 15 months ago, so I did not
quote that part, but interested parties can follow this thread:
http://thread.gmane.org/gmane.comp.version-control.git/3907/focus=4126
next prev parent reply other threads:[~2006-08-27 3:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-26 14:17 [PATCH] dir: do all size checks before seeking back and fix file closing Jonas Fonseca
2006-08-26 18:43 ` Mitchell Blank Jr
2006-08-26 20:44 ` Jonas Fonseca
2006-08-26 22:13 ` Linus Torvalds
2006-08-26 22:35 ` Jakub Narebski
2006-08-27 0:07 ` Junio C Hamano
2006-08-27 2:15 ` Junio C Hamano
2006-08-27 2:37 ` Linus Torvalds
2006-08-27 3:04 ` Junio C Hamano [this message]
2006-08-27 23:55 ` [PATCH] Use fstat instead of fseek Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy7tayj4d.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).