From: Junio C Hamano <junkio@cox.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: bugfix: a.list formatting regression
Date: Tue, 22 Aug 2006 16:14:58 -0700 [thread overview]
Message-ID: <7vy7tgl5vx.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <ecg1fd$3uj$2@sea.gmane.org> (Jakub Narebski's message of "Wed, 23 Aug 2006 00:46:09 +0200")
Jakub Narebski <jnareb@gmail.com> writes:
> Junio C Hamano wrote:
>
>> It might be worthwhile to do a full sweep of the pages we
>> generate and identify what classes we would want. I have a
>> feeling that we overuse a.list for example -- they are all in
>> some form of list alright but they might benefit from a bit
>> finer logical separatoin. One list is enumaration of refs and
>> another is a chronological sequence of commits.
>>
>> Then people who would want to tweak the presentation would have
>> an easier time changing only gitweb.css.
>
> Next patch in this series of patches
> [PATCH] gitweb: Replace some presentational HTML by CSS
> Message-Id: <11562431392439-git-send-email-jnareb@git.vger.kernel.org>
> adds "name" subclass (a.list.name) for ref names. (I think
> subclasses/multiple classes is the way to do it, as all a.list
> elements have something in common: use next class to divide).
I agree about the implementation aspect, such as using
"list.name" as class names; I was suggesting to start from
design.
next prev parent reply other threads:[~2006-08-22 23:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-22 8:55 [PATCH] gitweb: bugfix: list regression Luben Tuikov
2006-08-22 9:19 ` Junio C Hamano
2006-08-22 9:30 ` Jakub Narebski
2006-08-22 10:02 ` [PATCH] gitweb: bugfix: a.list formatting regression Jakub Narebski
2006-08-22 22:34 ` Junio C Hamano
2006-08-22 22:46 ` Jakub Narebski
2006-08-22 23:14 ` Junio C Hamano [this message]
2006-08-23 4:43 ` Luben Tuikov
2006-08-23 4:45 ` Luben Tuikov
2006-08-23 5:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy7tgl5vx.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).