From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <junkio@cox.net>
Subject: Re: [PATCH] Check and document the options to prevent mistakes.
Date: Wed, 21 Jun 2006 13:53:32 -0700
Message-ID: <7vy7vqxmb7.fsf@assigned-by-dhcp.cox.net>
References: <m164iu8x78.fsf@ebiederm.dsl.xmission.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Wed Jun 21 22:53:41 2006
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1Ft9hi-0002z7-0C
	for gcvg-git@gmane.org; Wed, 21 Jun 2006 22:53:38 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1030273AbWFUUxf (ORCPT <rfc822;gcvg-git@m.gmane.org>);
	Wed, 21 Jun 2006 16:53:35 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030274AbWFUUxe
	(ORCPT <rfc822;git-outgoing>); Wed, 21 Jun 2006 16:53:34 -0400
Received: from fed1rmmtao02.cox.net ([68.230.241.37]:20131 "EHLO
	fed1rmmtao02.cox.net") by vger.kernel.org with ESMTP
	id S1030273AbWFUUxe (ORCPT <rfc822;git@vger.kernel.org>);
	Wed, 21 Jun 2006 16:53:34 -0400
Received: from assigned-by-dhcp.cox.net ([68.4.9.127])
          by fed1rmmtao02.cox.net
          (InterMail vM.6.01.06.01 201-2131-130-101-20060113) with ESMTP
          id <20060621205333.GUHY12581.fed1rmmtao02.cox.net@assigned-by-dhcp.cox.net>;
          Wed, 21 Jun 2006 16:53:33 -0400
To: ebiederm@xmission.com (Eric W. Biederman)
In-Reply-To: <m164iu8x78.fsf@ebiederm.dsl.xmission.com> (Eric W. Biederman's
	message of "Wed, 21 Jun 2006 07:17:31 -0600")
User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)
Sender: git-owner@vger.kernel.org
Precedence: bulk
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/22287>

ebiederm@xmission.com (Eric W. Biederman) writes:

> +# Verify the user input
> +
> +foreach my $entry (@to) {
> +	die "Comma in --to entry: $entry'\n" unless $entry !~ m/,/;
> +}
> +

Perhaps, avoiding double negation would be easier on the eyes.

        die ... if $entry =~ /,/

Does it grok '"Biederman, Eric W." <eb@xm.com>' some people seem
to do properly, or do we care (I personally don't)?