* [PATCH] git-fetch-pack: really do not ask for funny refs
@ 2006-01-18 23:24 Johannes Schindelin
2006-01-19 0:33 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Schindelin @ 2006-01-18 23:24 UTC (permalink / raw)
To: git, junkio
If git-fetch-pack was called with out any refspec, it would ask the server
for funny refs. That cannot work, since the funny refs are not marked
as OUR_REF by upload-pack, which just exits with an error.
Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
fetch-pack.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
718ad2d76a6c7d350d63c0660aeb69518b765310
diff --git a/fetch-pack.c b/fetch-pack.c
index d34f322..27f5d2a 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -262,9 +262,6 @@ static void filter_refs(struct ref **ref
{
struct ref *prev, *current, *next;
- if (!nr_match)
- return;
-
for (prev = NULL, current = *refs; current; current = next) {
next = current->next;
if ((!memcmp(current->name, "refs/", 5) &&
--
1.1.3.g0bf8-dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] git-fetch-pack: really do not ask for funny refs
2006-01-18 23:24 [PATCH] git-fetch-pack: really do not ask for funny refs Johannes Schindelin
@ 2006-01-19 0:33 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2006-01-19 0:33 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: git
Good catch. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-19 0:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-18 23:24 [PATCH] git-fetch-pack: really do not ask for funny refs Johannes Schindelin
2006-01-19 0:33 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).