git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: Re: bad git pull
Date: Fri, 16 Dec 2005 17:49:23 -0800	[thread overview]
Message-ID: <7vy82kbiho.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0512161701400.3698@g5.osdl.org> (Linus Torvalds's message of "Fri, 16 Dec 2005 17:05:41 -0800 (PST)")

Linus Torvalds <torvalds@osdl.org> writes:

> Or maybe "git commit" should always _write_ ORIG_HEAD with the old head, 
> so that we can always do an "undo" by doing "git reset --hard ORIG_HEAD" 
> regardless of whether the last thing was a "git commit" or a "git pull".
>
> Hmm?

If we define "git undo" as "Revert the tree to the state one
before the last successfull commit/pull", then overwriting
ORIG_HEAD as you say at the commit time and always using "git
reset --hard ORIG_HEAD" would make sense.

I fail to see the merit of "git undo/unpull/unmerge/..."; mostly
because I have never seen BK and do not benefit from the
familiarity factor at all.  To people without BK experience,
having too many synonyms (e.g. "git undo" does something magical
by feeding "git reset --hard" with ORIG_HEAD) might be just more
noise and confusion.  I can see them asking "why are there two
ways to do identical things?".

However, the reason I am maintaining git is not to make it
useful for _me_, but to make it useful for the kernel people, so
if these BK-like synonyms help them, I'm all for it.  If we are
going to do that, somebody needs to describe what should each
command do in each case in detail, because I do not know BK at
all.

You guys were on BK for how many months, and have been on git
for how many months now?  Do BK-familiarity factor matter, and
will it continue to matter for how long?

  reply	other threads:[~2005-12-17  1:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-15 23:37 bad git pull Don Zickus
2005-12-15 23:42 ` Junio C Hamano
2005-12-15 23:53   ` Junio C Hamano
2005-12-16 15:39     ` Don Zickus
2005-12-16 17:40       ` Junio C Hamano
2005-12-16 17:25     ` Carl Baldwin
2005-12-16 19:20       ` Junio C Hamano
2005-12-16 18:07     ` Morten Welinder
2005-12-16 19:21       ` Junio C Hamano
2005-12-16 22:12         ` Linus Torvalds
2005-12-17  0:37           ` Morten Welinder
2005-12-17  1:05             ` Linus Torvalds
2005-12-17  1:49               ` Junio C Hamano [this message]
2005-12-17  7:44                 ` Linus Torvalds
2005-12-17  9:28                   ` Junio C Hamano
2005-12-17 21:04                     ` Nicolas Pitre
2005-12-18  3:02                       ` Junio C Hamano
2005-12-18  4:17                         ` Nicolas Pitre
2005-12-18  6:31                           ` Linus Torvalds
2005-12-18  7:15                           ` Junio C Hamano
2005-12-18 17:16                             ` Nicolas Pitre
2005-12-17  2:19             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vy82kbiho.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).