git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jason Riedy <ejr@EECS.Berkeley.EDU>, git@vger.kernel.org
Subject: Re: [PATCH] Add compat/setenv.c, use in git.c.
Date: Sun, 04 Dec 2005 14:24:22 -0800	[thread overview]
Message-ID: <7vy830ec15.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <43935A9E.2060602@zytor.com> (H. Peter Anvin's message of "Sun, 04 Dec 2005 13:07:42 -0800")

"H. Peter Anvin" <hpa@zytor.com> writes:

> Wouldn't this be a good case for using alloca()?

Perhaps, but considering that (1) this function is not something
frequently called anyway, and (2) the proposed change would make
it the first alloca() user, and (3) this is compatibility
replacement function, I'd rather choose to keep it "old, known
to work at more places" malloc/free pair, and not having to
worry about it.

But now you quote the patch, sizeof(char) looks funny.  Isn't it
always 1 by definition?

  reply	other threads:[~2005-12-04 22:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-02 23:08 [PATCH] Add compat/setenv.c, use in git.c Jason Riedy
2005-12-04  6:26 ` Junio C Hamano
2005-12-04 21:07 ` H. Peter Anvin
2005-12-04 22:24   ` Junio C Hamano [this message]
2005-12-04 22:31   ` Junio C Hamano
2005-12-04 23:34     ` H. Peter Anvin
2005-12-05 18:07     ` Jason Riedy
2005-12-05 18:39       ` H. Peter Anvin
2005-12-06  3:35       ` Junio C Hamano
2005-12-06 19:59         ` Jason Riedy
2005-12-06 21:10           ` Morten Welinder
2005-12-06 21:41             ` Junio C Hamano
2005-12-06 22:18               ` Jason Riedy
2005-12-07  0:58               ` Morten Welinder
2005-12-04 23:01 ` [PATCH] compat/setenv: do not free what we fed putenv(3) Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vy830ec15.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=ejr@EECS.Berkeley.EDU \
    --cc=git@vger.kernel.org \
    --cc=hpa@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).