From: Junio C Hamano <junkio@cox.net>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
Fredrik Kuivinen <freku045@student.liu.se>,
"H. Peter Anvin" <hpa@zytor.com>,
git@vger.kernel.org
Subject: Re: Moved files and merges
Date: Sat, 03 Sep 2005 11:46:53 -0700 [thread overview]
Message-ID: <7vy86erntu.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <7vek867e29.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Sat, 03 Sep 2005 01:25:50 -0700")
This is a simplified scenario of klibc vs klibc-kbuild HPA had
trouble with, to help us think of a way to solve this
interesting merge problem.
#1 - #3 - #5 - #7
/ / /
#0 - #2 - #4 - #6
There are two lines of developments. #0->#2 renames F to G and
introduces K. #0->#1 keeps F as F and does not introduce K.
At commit #3, #2 is merged into #1. The changes made to the
file contents of F between #0 and #2 are appreciated, but the
renaming of F to G and introduction of K were not. So commit #3
has the resulting merge contents in F and does not have file K.
This _might_ be different from what we traditionally consider a
'merge', but from the use case point of view it is a valid thing
one would want to do.
Commit #4 is a continued development from #2; changes are made
to G, and K has further changes. Commit #5 similarly is a
continued development from #3; its changes are in F and K does
not exist.
We are about to merge #6 into #5 to create #7. We should be
able to take advantage of what the user did when the merge #3
was made; namely, we should be able to infer that the line of
development that flows #0 .. #3 .. #7 prefers to keep F as F,
and does not want the newly introduced K. We should be able to
tell it by looking at what the merge #3 did.
Now, how can we use git to figure that out?
First, given our current head (#5) and the other head we are
about to merge (#6), we need a way to tell if we merged from
them before (i.e. the existence of #3) and if so the latest of
such merge (i.e. #3).
The merge base between #5 and #6 is #2. We can look at commits
between us (#5) and the merge base (#2), find a merge (#3),
which has two parents. One of the parents is #2 which is
reachable from #6, and the other is #1 which is not reachable
from #6 but is reachable from #5. Can we say that this reliably
tells us that #2 is on their side and #1 is on our side? Does
the fact that #3 is the commit topologically closest to #5 tell
us that #3 is the one we want to look deeper?
This is still handwaving, but assuming the answers to these
questions are yes, we have found that the 'previous' merge is
#3, that #1 is its parent on our side, and that #2 is its parent
on their side.
Then we can ask 'diff-tree -M #2 #3' to see what `tree
structure` changes we do _not_ want from their line of
development, while slurping the contents changes from them.
When making the tree to put at #7, just like I outlined to my
previous message to HPA, we can first create a tree that is a
derivative of #6 with only the structural changes detected
between #2 and #3 (which are 'rename from G to F' and 'removal
of K') applied. Similarly, we make another derivative, this
time of #2, with only the structural changes to adjust it to
'our' tree (again, 'rename from G to F' and 'removal of K').
Then we can run 3-way git-read-tree like this:
git-read-tree -m -u '#2-adjusted' '#5' '#6-adjusted'
The last part, using the structurally adjusted tree as the
merge-base tree, is what I forgot to do in the previous message
to HPA.
Hmm.
next prev parent reply other threads:[~2005-09-03 18:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-02 23:59 Moved files and merges H. Peter Anvin
2005-09-03 0:20 ` Martin Langhoff
2005-09-04 4:14 ` H. Peter Anvin
2005-09-03 1:36 ` Junio C Hamano
2005-09-03 8:25 ` Junio C Hamano
2005-09-03 18:06 ` Fredrik Kuivinen
2005-09-03 18:53 ` Junio C Hamano
2005-09-03 18:46 ` Junio C Hamano [this message]
2005-09-03 19:05 ` Sam Ravnborg
2005-09-03 19:32 ` Junio C Hamano
2005-09-03 22:03 ` Sam Ravnborg
2005-09-04 7:32 ` Junio C Hamano
2005-09-04 18:28 ` Daniel Barkalow
2005-09-04 19:10 ` Junio C Hamano
2005-09-05 15:16 ` H. Peter Anvin
2005-09-05 15:47 ` Linus Torvalds
2005-09-05 16:37 ` H. Peter Anvin
2005-09-05 18:08 ` Junio C Hamano
2005-09-05 18:33 ` Junio C Hamano
2005-09-05 18:43 ` H. Peter Anvin
2005-09-04 8:27 ` Junio C Hamano
2005-09-03 19:21 ` Fredrik Kuivinen
2005-09-03 18:59 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy86erntu.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=barkalow@iabervon.org \
--cc=freku045@student.liu.se \
--cc=git@vger.kernel.org \
--cc=hpa@zytor.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).